gh-104400: Add more tests to pygettext #108173
Add a CLI command to regenerate snapshots
- Loading branch information
commit 5fba1bbabf5097bc9a8f74a77a8d8383d38c403b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -384,3 +384,24 @@ def test_files_list(self): | |
| self.assertIn(f'msgid "{text1}"', data) | ||
| self.assertIn(f'msgid "{text2}"', data) | ||
| self.assertNotIn(text3, data) | ||
|
|
||
|
|
||
| def update_POT_snapshots(): | ||
| for input_file in DATA_DIR.glob('*.py'): | ||
| output_file = input_file.with_suffix('.pot') | ||
| contents = input_file.read_text(encoding='utf-8') | ||
| with temp_cwd(None): | ||
| Path(input_file.name).write_text(contents) | ||
| assert_python_ok(Test_pygettext.script, '--docstrings', input_file.name) | ||
| output = Path('messages.pot').read_text() | ||
|
There was a problem hiding this comment. When you read text, always specify the encoding. There was a problem hiding this comment. This causes problems on Windows, where the encoding is There was a problem hiding this comment. We should use |
||
|
|
||
| output = normalize_POT_file(output) | ||
| output_file.write_text(output, encoding='utf-8') | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| # To regenerate POT files | ||
| if len(sys.argv) > 1 and sys.argv[1] == '--snapshot-update': | ||
| update_POT_snapshots() | ||
| sys.exit(0) | ||
| unittest.main() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some files with non-UTF-8 encoding.
Since
contentsis only used to copy a file, you can read/write the binary content.