[3.12] gh-108083: Don't ignore exceptions in sqlite3.Connection.init() and .close() (#108084) #108141

erlend-aasland · 2023-08-19T16:00:14Z

Add explanatory comments
Add return value to connection_close() for propagating errors
Always check the return value of connection_exec_stmt()
Assert pre/post state in remove_callbacks()
Don't log unraisable exceptions in case of interpreter shutdown
Make sure we're not initialized if reinit fails
Try to close the database even if ROLLBACK fails

(cherry picked from commit fd19509)

Co-authored-by: Victor Stinner vstinner@python.org
Co-authored-by: Serhiy Storchaka storchaka@gmail.com

Issue: sqlite3: some code paths ignore exceptions #108083

….__init__() and .close() (python#108084) - Add explanatory comments - Add return value to connection_close() for propagating errors - Always check the return value of connection_exec_stmt() - Assert pre/post state in remove_callbacks() - Don't log unraisable exceptions in case of interpreter shutdown - Make sure we're not initialized if reinit fails - Try to close the database even if ROLLBACK fails (cherry picked from commit fd19509) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

erlend-aasland requested a review from berkerpeksag as a code owner August 19, 2023 16:00

This was referenced Aug 19, 2023

sqlite3: some code paths ignore exceptions #108083

Closed

gh-108083: Don't ignore exceptions in sqlite3.Connection.__init__() and .close() #108084

Merged

bedevere-bot added the awaiting core review label Aug 19, 2023

Yhg1s merged commit 0c21298 into python:3.12 Aug 19, 2023

bedevere-bot removed the awaiting core review label Aug 19, 2023

erlend-aasland deleted the backport-3.12-harden-sqlite branch August 22, 2023 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.12] gh-108083: Don't ignore exceptions in sqlite3.Connection.init() and .close() (#108084) #108141

[3.12] gh-108083: Don't ignore exceptions in sqlite3.Connection.init() and .close() (#108084) #108141

[3.12] gh-108083: Don't ignore exceptions in sqlite3.Connection.__init__() and .close() (#108084) #108141

[3.12] gh-108083: Don't ignore exceptions in sqlite3.Connection.__init__() and .close() (#108084) #108141

Conversation

[3.12] gh-108083: Don't ignore exceptions in sqlite3.Connection.init() and .close() (#108084) #108141

[3.12] gh-108083: Don't ignore exceptions in sqlite3.Connection.init() and .close() (#108084) #108141