8000 GH-83417: Allow `venv` to add a `.gitignore` file to environments via a new `scm_ignore_file` parameter by brettcannon · Pull Request #108125 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-83417: Allow venv to add a .gitignore file to environments via a new scm_ignore_file parameter #108125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 15, 2023
Merged

GH-83417: Allow venv to add a .gitignore file to environments via a new scm_ignore_file parameter #108125

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f889dc6
GH-83417: Allow `venv` add a `.gitignore` file to environments
brettcannon Aug 18, 2023
1faf4b0
Add a news entry
brettcannon Aug 18, 2023
31d0558
Apply suggestions from code review
brettcannon Aug 21, 2023
41e541c
Merge branch 'main' into issue-83417-venv-gitignore
brettcannon Aug 21, 2023
ce17684
Switch to `scm_ignore_file`
brettcannon Sep 4, 2023
90eb700
Merge branch 'main' into issue-83417-venv-gitignore
brettcannon Sep 6, 2023
c3b96e0
Make `scm_ignore_files` accept an iterable
brettcannon Sep 10, 2023
a8528dd
Merge branch 'main' into issue-83417-venv-gitignore
brettcannon Sep 10, 2023
ddc2225
Update Doc/library/venv.rst
brettcannon Sep 10, 2023
547879d
Fix capitalization of "Git"
brettcannon Sep 11, 2023
8ba65b5
Merge branch 'main' into issue-83417-venv-gitignore
brettcannon Sep 11, 2023
f75b26c
Add a What's new entry
brettcannon Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
  • Loading branch information
@brettcannon @AA-Turner
brettcannon and AA-Turner authored Aug 21, 2023
commit 31d0558748a1a4f55d6705e07be7ca21007d18d8
4 changes: 2 additions & 2 deletions Doc/library/venv.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ creation according to their needs, the :class:`EnvBuilder` class.

.. class:: EnvBuilder(system_site_packages=False, clear=False, \
symlinks=False, upgrade=False, with_pip=False, \
prompt=None, upgrade_deps=False, \*, gitignore=False)
prompt=None, upgrade_deps=False, *, gitignore=False)

The :class:`EnvBuilder` class accepts the following keyword arguments on
instantiation:
Expand Down Expand Up @@ -350,7 +350,7 @@ There is also a module-level convenience function:

.. function:: create(env_dir, system_site_packages=False, clear=False, \
symlinks=False, with_pip=False, prompt=None, \
upgrade_deps=False, \*, gitignore=False)
upgrade_deps=False, *, gitignore=False)

Create an :class:`EnvBuilder` with the given keyword arguments, and call its
:meth:`~EnvBuilder.create` method with the *env_dir* argument.
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_venv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def test_config_file_command_key(self):
b = venv.EnvBuilder()
else:
b = venv.EnvBuilder(
**{attr: False if attr in negated_attrs else True})
**{attr: attr not in negated_attrs})
b.upgrade_dependencies = Mock() # avoid pip command to upgrade deps
b._setup_pip = Mock() # avoid pip setup
self.run_with_capture(b.create, self.env_dir)
Expand Down
0