8000 gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py by iritkatriel · Pull Request #107971 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py #107971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 16, 2023
Merged

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py #107971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0811c6d
gh-105481: allocate op IDs in cases generator. Generate _PyOpcode_Deo…
iritkatriel Aug 14, 2023
a10a14d
_PyOpcode_OpName generated by cases_generator
iritkatriel Aug 14, 2023
eecc84c
remove include
iritkatriel Aug 14, 2023
96bbc8f
replacement for opcode_targets.h
iritkatriel Aug 14, 2023
e68fc03
generate opcode IDs from bytecodes.c
iritkatriel Aug 14, 2023
f04d3eb
remove opcode IDs from opcode.py. Update tests and fix specialized op…
iritkatriel Aug 15, 2023
e7833dd
fix magic number
iritkatriel Aug 15, 2023
99a408b
rename function
iritkatriel Aug 15, 2023
7615eff
add news
iritkatriel Aug 15, 2023
2f67ea8
update windows makefile
iritkatriel Aug 15, 2023
d6ecee1
remove _specialized_instructions, we have the same in _specialized_op…
iritkatriel Aug 15, 2023
7337a4b
gh-103082: remove assumption that INSTRUMENTED_LINE is the last instr…
iritkatriel Aug 15, 2023
0d6ed4b
assert 255 is not used
iritkatriel Aug 15, 2023
1d55078
fix _co_firsttraceable calculation in deepfreeze.py
iritkatriel Aug 16, 2023
50415d5
update RESUME hard coded value (argh)
iritkatriel Aug 16, 2023
5543e7c
Merge remote-tracking branch 'upstream/main' into deopt
iritkatriel Aug 16, 2023
d39233e
hard code RESUME. Make sure opmaps are sorted by ID
iritkatriel Aug 16, 2023
f5e4c1d
implemented suggestions from code review
iritkatriel Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replacement for opcode_targets.h
  • Loading branch information
@iritkatriel
iritkatriel committed Aug 14, 2023
commit 96bbc8f17f42605c00c6f6370a0939c96cba948d
261 changes: 261 additions & 0 deletions Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions Tools/cases_generator/generate_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,17 @@ def write_metadata(self, metadata_filename: str, pymetadata_filename: str) -> No
for name in self.opmap:
self.out.emit(f'[{name}] = "{name}",')

self.out.emit("")
self.out.emit("#if USE_COMPUTED_GOTOS")
self.out.emit("/* Static jump table */")
with self.out.block("static void *new_opcode_targets[256]=", ";"):
targets = ["_unknown_opcode"] * 256
for name, op in self.opmap.items():
if op < 256:
targets[op] = f"TARGET_{name}"
f.write(",\n".join([f" &&{s}" for s in targets]))
self.out.emit("#endif /* USE_COMPUTED_GOTOS */")

with self.metadata_item(
f"const uint8_t _PyOpcode_Deopt[256]", "=", ";"
):
Expand Down
0