8000 GH-105848: Simplify the arrangement of `CALL`'s stack by brandtbucher · Pull Request #107788 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-105848: Simplify the arrangement of CALL's stack #107788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2023
Merged

GH-105848: Simplify the arrangement of CALL's stack #107788

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80fa37a
Clean up the call sequence
brandtbucher Aug 5, 2023
f565bc6
blurb add
brandtbucher Aug 5, 2023
b48c86d
Fix doctest
brandtbucher Aug 5, 2023
fd6607f
Bump the magic number
brandtbucher Aug 5, 2023
a5a2d8f
DSL cleanup
brandtbucher Aug 5, 2023
47009af
More tweaks
brandtbucher Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump the magic number
  • Loading branch information
@brandtbucher
brandtbucher committed Aug 5, 2023
commit fd6607f04afbba52c7d75418364a0845ebdcd8b3
3 changes: 2 additions & 1 deletion Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ def _write_atomic(path, data, mode=0o666):
# Python 3.13a1 3555 (generate specialized opcodes metadata from bytecodes.c)
# Python 3.13a1 3556 (Convert LOAD_CLOSURE to a pseudo-op)
# Python 3.13a1 3557 (Make the conversion to boolean in jumps explicit)
# Python 3.13a1 3558 (Reorder the stack items for CALL)

# Python 3.14 will start with 3600

Expand All @@ -469,7 +470,7 @@ def _write_atomic(path, data, mode=0o666):
# Whenever MAGIC_NUMBER is changed, the ranges in the magic_values array
# in PC/launcher.c must also be updated.

MAGIC_NUMBER = (3557).to_bytes(2, 'little') + b'\r\n'
MAGIC_NUMBER = (3558).to_bytes(2, 'little') + b'\r\n'

_RAW_MAGIC_NUMBER = int.from_bytes(MAGIC_NUMBER, 'little') # For import.c

Expand Down
0