Apply suggestions from code review

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
python · erlend-aasland · Aug 10, 2023 · Aug 8, 2023 · Aug 8, 2023 · Aug 8, 2023
commit e56888c400d1edc0dd64f3a4c9f4c98f94d78663
@@ -2436,7 +2436,7 @@ def check_depr_star(self, pnames, fn, *args, **kwds):
         regex = (
             fr"Passing( more than)?( [0-9]+)? positional argument(s)? to "
             fr"{fn.__name__}\(\) is deprecated. Parameter(s)? {pnames} will "
-            fr"become( a)? keyword-only parameter(s)? in Python 3.14"
+            fr"become( a)? keyword-only parameter(s)? in Python 3\.14"
         )
         with self.assertWarnsRegex(DeprecationWarning, regex) as cm:
             # Record the line number, so we're sure we've got the correct stack
@@ -2915,17 +2915,19 @@ def test_depr_star_new(self):
             "deprecated. Parameter 'a' will become a keyword-only parameter "
             "in Python 3.14."
         )
-        with self.assertWarnsRegex(DeprecationWarning, regex):
+        with self.assertWarnsRegex(DeprecationWarning, regex) as cm:
             ac_tester.DeprStarNew(None)
+        self.assertEqual(cm.filename, __file__)
 
     def test_depr_star_init(self):
         regex = re.escape(
             "Passing positional arguments to _testclinic.DeprStarInit() is "
             "deprecated. Parameter 'a' will become a keyword-only parameter "
             "in Python 3.14."
         )
-        with self.assertWarnsRegex(DeprecationWarning, regex):
+        with self.assertWarnsRegex(DeprecationWarning, regex) as cm:
             ac_tester.DeprStarInit(None)
+        self.assertEqual(cm.filename, __file__)
 
     def test_depr_star_pos0_len1(self):
         fn = ac_tester.depr_star_pos0_len1

diff --git a/Modules/_testclinic.c b/Modules/_testclinic.c
@@ -1227,11 +1227,7 @@ static PyObject *
 depr_star_new_impl(PyTypeObject *type, PyObject *a)
 /*[clinic end generated code: output=bdbb36244f90cf46 input=f4ae7dafbc23c378]*/
 {
-    PyObject *self = type->tp_alloc(type, 0);
-    if (self == NULL) {
-        return NULL;
-    }
-    return self;
+    return type->tp_alloc(type, 0);
 }
 
 static PyTypeObject DeprStarNew = {