8000 bpo-33723: Remove thread_time/process_time functional tests by vstinner · Pull Request #10773 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-33723: Remove thread_time/process_time functional tests 8000 #10773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

bpo-33723: Remove thread_time/process_time functional tests #10773

merged 1 commit into from
Nov 28, 2018

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Nov 28, 2018 •
edited by bedevere-bot
Loading

Functional tests of test_thread_time() and test_process_time() are
not reliable on Windows. Remove these tests. Only keep the minimum
tests.

https://bugs.python.org/issue33723

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Nov 28, 2018
@vstinner
Copy link
Member Author

@pitrou approved my previous attempt: PR #10723.

@vstinner
bpo-33723: Remove busy loop from test_time
1d2b7b4 
The "busy loops" of test_process_time() and test_thread_time() are
not reliable and fail randomly on Windows: remove them.
@vstinner vstinner merged commit 48498dd into python:master Nov 28, 2018
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@vstinner vstinner deleted the thread_time branch November 28, 2018 17:30
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2018
@vstinner @miss-islington
bpo-33723: Remove busy loop from test_time (pythonGH-10773)
daf2496 
The "busy loops" of test_process_time() and test_thread_time() are
not reliable and fail randomly on Windows: remove them.
(cherry picked from commit 48498dd)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

GH-10776 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 28, 2018
@miss-islington @vstinner
bpo-33723: Remove busy loop from test_time (GH-10773)
d46d753 
The "busy loops" of test_process_time() and test_thread_time() are
not reliable and fail randomly on Windows: remove them.
(cherry picked from commit 48498dd)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni
0