8000 GH-107724: Fix the signature of `PY_THROW` callback functions. by markshannon · Pull Request #107725 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-107724: Fix the signature of PY_THROW callback functions. #107725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 9, 2023
Merged

GH-107724: Fix the signature of PY_THROW callback functions. #107725

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16632de
Make signature of PY_THROW callabck match other exception monitoring …
markshannon Aug 4, 2023
dac7358
Add news
markshannon Aug 4, 2023
119e206
Add test for PY_THROW
markshannon Aug 4, 2023
8f1380b
Fix legacy tracing shim
markshannon Aug 4, 2023
8fe9166
Remove debugging code
markshannon Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix legacy tracing shim
  • Loading branch information
@markshannon
markshannon committed Aug 4, 2023
commit 8f1380b61542605be4583d681671d14f4b94797b
6 changes: 3 additions & 3 deletions Python/legacy_tracing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ sys_trace_func2(
}

static PyObject *
sys_trace_unwind(
sys_trace_func3(
_PyLegacyEventHandler *self, PyObject *const *args,
size_t nargsf, PyObject *kwnames
) {
Expand Down Expand Up @@ -445,7 +445,7 @@ _PyEval_SetTrace(PyThreadState *tstate, Py_tracefunc func, PyObject *arg)
return -1;
}
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
(vectorcallfunc)sys_trace_func2, PyTrace_CALL,
(vectorcallfunc)sys_trace_func3, PyTrace_CALL,
PY_MONITORING_EVENT_PY_THROW, -1)) {
return -1;
}
Expand All @@ -470,7 +470,7 @@ _PyEval_SetTrace(PyThreadState *tstate, Py_tracefunc func, PyObject *arg)
return -1;
}
if (set_callbacks(PY_MONITORING_SYS_TRACE_ID,
(vectorcallfunc)sys_trace_unwind, PyTrace_RETURN,
(vectorcallfunc)sys_trace_func3, PyTrace_RETURN,
PY_MONITORING_EVENT_PY_UNWIND, -1)) {
return -1;
}
Expand Down
0