GH-100964: Break cycles involving exception state when returning from generator #107563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 8ea8408 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
iritkatriel
approved these changes
Aug 2, 2023
|
All the buildbots were already failing, so sadly the failures tell us nothing. |
|
I don't think this PR can cause new leaks. It's making us clear more than before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #100964.
Even if it doesn't fix the issue, it seems better to clear the exception state as soon as the generator is exhausted.
If it works we can consider a backport.