gh-107545: Fix misleading setsockopt error message #107546
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
|
I choose to solve the issue using a white-list approach rather then a black-list approach since there might be more errors that Error message for: import socket
with socket.socket() as s:
s.setsockopt(socket.SOL_SOCKET, socket.SO_RCVBUF, 2 ** 31)is now |
|
Looks good, how about adding some tests for new error messages. |
Misc/NEWS.d/next/Core and Builtins/2023-08-01-22-30-35.gh-issue-107545.f9i3pQ.rst
Outdated
Show resolved
Hide resolved
|
I added the relevant tests. Any new review comments? |
Considering this is your first PR in cpython, please be patient! The next step is waiting for the review by core devs. Generally, core developers don't have enough time to review every PR, so you can see there are many PRs that can't be merged into the main. Before they come to review, we just need to keep our PR compliant and wait :) |
|
All commit authors signed the Contributor License Agreement. |
f712b65 to
6439014
Compare
6439014 to
167d212
Compare
|
Since this PR is old, I validated that the issue is still reproducible. |
According to Python's documentation,
setsockoptcan get eitherint,bufferorNoneas the third argument.The way it is currently implemented is by trying to parse all of the three arguments as ints, if this fails no matter what the reason is we just try the next overload.
Since
2**31causesPyExc_OverflowErrorwe try the next overloads. Because thebufferoverload is last we get type error for the third argument instead ofOverflowError(e.g.TypeError: a bytes-like object is required, not 'int').setsockopterror message #107545