10000 Remove newlines from bug template by hugovk · Pull Request #107525 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Remove newlines from bug template #107525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

Remove newlines from bug template #107525

merged 1 commit into from
Aug 1, 2023

Conversation

hugovk
Copy link
Member
@hugovk hugovk commented Aug 1, 2023

Follow on from #107150, cc @AlexWaygood.

With Markdown like this:

- [ ] I am confident this is a bug in CPython,
      not a bug in a third-party project
- [ ] I have searched the CPython issue tracker,
      and am confident this bug has not been reported before

GitHub correctly elides the newlines out when viewing the template file directly:

image

But adds hard newlines when rendering it in an issue. For example: #107515

image

It's looks a bit odd and is not such a problem for desktop layouts, but is worse on mobile:

@hugovk hugovk requested a review from ezio-melotti as a code owner August 1, 2023 05:57
AlexWaygood
AlexWaygood approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was on my to-do list for today!

@hugovk hugovk merged commit 052a0d1 into python:main Aug 1, 2023
@hugovk hugovk deleted the update-bug-t 7E29 emplate branch August 1, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @AlexWaygood @bedevere-bot
0