8000 bpo-33012: Add _Py_CAST_FUNC() to cast function ptr by vstinner · Pull Request #10744 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-33012: Add _Py_CAST_FUNC() to cast function ptr #10744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-33012: Add _Py_CAST_FUNC() to cast function ptr #10744

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Nov 27, 2018 •
edited by bedevere-bot
Loading

Use _Py_CAST_FUNC() to cast functions pointers to getter, setter,
destructor, etc.

Change mostly written in gvim using the command:

:%s!(\(inquiry\|destructor\|reprfunc\|getter\|setter
 \|releasebufferproc\|getbufferproc\))
 \([A-Za-z0-9_]\+\)
 !_Py_CAST_FUNC(\1, \2)!g

https://bugs.python.org/issue33012

@vstinner
bpo-33012: Add _Py_CAST_FUNC() to cast function ptr
8000
b9c8770 
Use _Py_CAST_FUNC() to cast functions pointers to getter, setter,
destructor, etc.

Change mostly written in gvim using the command:

    :%s!(\(inquiry\|destructor\|reprfunc\|getter\|setter
     \|releasebufferproc\|getbufferproc\))
     \([A-Za-z0-9_]\+\)
     !_Py_CAST_FUNC(\1, \2)!g
@serhiy-storchaka
Copy link
Member

The problem is not in warnings, but in incorrect function signatures. This PR just silences valid compiler warnings. See #10746.

@vstinner
Copy link
Member Author

The problem is not in warnings, but in incorrect function signatures.

What do you mean by "incorrect function signature"? Example:

static PyObject *
method_get_doc(PyMethodDescrObject *descr, void *closure)
{
    return _PyType_GetDocFromInternalDoc(descr->d_method->ml_name, descr->d_method->ml_doc);
}

static PyGetSetDef method_getset[] = {
    {"__doc__", (getter)method_get_doc},
    ...
};

Here the warning is that PyGetSetDef expects PyObject* as the first argument of the getter, whereas method_getset uses PyMethodDescrObject*. Is it an invalid signature? Would you prefer to write:

static PyObject *
method_get_doc(PyObject *descr_obj, void *closure)
{
    PyMethodDescrObject *descr = (PyMethodDescrObject *)descr_obj;
    return _PyType_GetDocFromInternalDoc(descr->d_method->ml_name, descr->d_method->ml_doc);
}

which is the "correct" signature? The additional "PyMethodDescrObject *descr = (PyMethodDescrObject *)descr_obj;" doesn't seem to provide any value to the compiler nor to the developer who read/maintain the code.

The problem is not in warnings, but in incorrect function signatures. This PR just silences valid compiler warnings. See #10746.

Right, that's a good fix, but I was too lazy to check each function pointer.

@serhiy-storchaka
Copy link
Member
serhiy-storchaka commented Nov 27, 2018 •
edited by bedevere-bot
Loading

I did not get a warning for method_get_doc. Could you please attach the output of the compiler to bpo-33012?

@vstinner
Copy link
Member Author

@serhiy-storchaka: Oh wow, I don't understand how it's possible, but almost all GCC warnings are gone. It seems like I didn't try on your latest compiler warning fix. So this PR is completely useless!

@vstinner vstinner closed this Nov 30, 2018
@vstinner vstinner deleted the cast_func branch November 30, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
0