[3.12] gh-105268: Remove _PyGC_FINALIZED() macro (#105350) #107348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2023
Closed
|
This change fix PyTorch: #105268 (comment) |
serhiy-storchaka
approved these changes
Jul 28, 2023
Remove the old private, undocumented and untested _PyGC_FINALIZED() macro which was kept for backward compatibility with Python 3.8 and older. (cherry picked from commit 8ddf0dd)
a31167b to
149ad93
Compare
|
@Yhg1s: Is this fix eligible in Python 3.12 final? It helps building PyTorch with Python 3.12 if I get it correctly. |
|
I rebased my PR fix to fix a CI issue. Sadly, 3 weeks ago, the backport couldn't be merged because of a flaky test which failed on the Ubuntu job (unrelated to this PR). |
|
Removing a macro helps building with PyTorch? That doesn't sound like a straight-forward case. But no, I see no reason this should go into 3.12 (not even two weeks ago, let alone at this stage). |
AFF1
|
Ok, in that case, I prefer to not backport this change to 3.12. I close the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the old private, undocumented and untested _PyGC_FINALIZED() macro which was kept for backward compatibility with Python 3.8 and older.
(cherry picked from commit 8ddf0dd)
📚 Documentation preview 📚: https://cpython-previews--107348.org.readthedocs.build/