-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-106149: Simplify stack depth calculation. Replace asserts by exceptions. #107255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
962e87c
gh-106149: Simplify stack depth calculation. Replace asserts by excep…
iritkatriel 1cea1e4
increment g_maxdepth when adding RETURN_GENERATOR (matches previous s…
iritkatriel ead648f
Revert "increment g_maxdepth when adding RETURN_GENERATOR (matches pr…
iritkatriel a2fa3cb
move the call to _PyCfg_Stackdepth back to compile.c. return value only
iritkatriel e546717
assert that stackdepth is not 0 when it's a generator
iritkatriel fce0919
remove redundant assert. Explain the next one.
iritkatriel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
8000
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
remove redundant assert. Explain the next one.
- Loading branch information
commit fce09194f14c71b3b2bf86ec468667cc434fa2b3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this explanation is accurate? This function is a generator:
Here is the disassembly of it:
I think if
RETURN_CONST
didn't exist, it would be enough to say "all functions must return a value, which always must go on the stack before it is returned." But withRETURN_CONST
that's not true either. It really does seem like theStopIteration
handler is what we are relying on here.