8000 gh-107017: removed mention that C does it the same way by JakubDotPy · Pull Request #107020 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-107017: removed mention that C does it the same way #107020

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 23, 2023
Merged

gh-107017: removed mention that C does it the same way #107020

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5742c7e
removed mention that C does it the same way
JakubDotPy Jul 22, 2023
67534f2
there are no "usual" flow control statements
JakubDotPy Jul 22, 2023
a588abc
implemented suggestions
JakubDotPy Jul 22, 2023
6acff0c
fixed typo and a line length
JakubDotPy Jul 22, 2023
5d08a1b
better structuring of the "else" explanation
JakubDotPy Jul 22, 2023
e4f676a
removed links
JakubDotPy Jul 22, 2023
9c34614
added keyword formatting
JakubDotPy Jul 22, 2023
8f08838
removed link
JakubDotPy Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
there are no "usual" flow control statements 
the reader may not know any control flow statements or other languages,
also the "twists" may feel too intimidating
  • Loading branch information
@JakubDotPy
JakubDotPy committed Jul 22, 2023
commit 67534f2bf3aa04617d3c67f1b74e27f9743e20e6
6 changes: 3 additions & 3 deletions Doc/tutorial/controlflow.rst
View file 8000
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
More Control Flow Tools
***********************

Besides the :keyword:`while` statement just introduced, Python uses the usual
flow control statements known from other languages, with some twists.
Besides the :keyword:`while` statement just introduced, Python uses a few more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As well as" would be more idiomatic English than "besides".

that will be introduced in this chapter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... that we will encounter..."



.. _tut-if:
Expand Down Expand Up @@ -166,7 +166,7 @@ arguments. In chapter :ref:`tut-structures`, we will discuss in more detail abo
The :keyword:`break` statement breaks out of the innermost enclosing
:keyword:`for` or :keyword:`while` loop.

Loop statements may have an :keyword:`!else` clause; it is executed when the loop
The :keyword:`for` loop statements may have an extra :keyword:`!else` clause; it is executed when the loop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the line length needs to be checked here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just seems bad. You restricted it to for statements, but it also applies to while statements. And the else clause isn't really "extra" (I even checked some dictionaries, they all defined it like "added to an existing or usual amount or number; additional. Example: they offered him an extra thirty-five cents an hour". And loop statements can only have one else clause.)

terminates through exhaustion of the iterable (with :keyword:`for`) or when the
condition becomes false (with :keyword:`while`), but not when the loop is
terminated by a :keyword:`break` statement. This is exemplified by the
Expand Down
0