8000 gh-106892: Use roles :data: and :const: for referencing module variables by serhiy-storchaka · Pull Request #106894 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-106892: Use roles :data: and :const: for referencing module variables #106894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2023
Merged

gh-106892: Use roles :data: and :const: for referencing module variables #106894

merged 1 commit into from
Jul 21, 2023

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Jul 19, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 19, 2023
Closed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 19, 2023
@serhiy-storchaka serhiy-storchaka marked this pull request as draft July 19, 2023 15:24
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review July 20, 2023 09:02
@serhiy-storchaka serhiy-storchaka merged commit d036db7 into python:main Jul 21, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker d036db728ea3d54509cbad06df74e2d9a31fbec8 3.12

@serhiy-storchaka serhiy-storchaka deleted the docs-data-const-roles branch July 21, 2023 09:34
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d036db728ea3d54509cbad06df74e2d9a31fbec8 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.12] pythongh-106892: Use roles :data: and :const: for referencing …
0ff3e1c 
…module variables (pythonGH-106894)

(cherry picked from commit d036db7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106954 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 21, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.11] pythongh-106892: Use roles :data: and :const: for referencing …
3187235 
…module variables (pythonGH-106894).

(cherry picked from commit d036db7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106955 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 21, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 21, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.11] gh-106892: Use roles :data: and :const: for referencing module…
cc76113 
… variables (GH-106894) (GH-106955)

(cherry picked from commit d036db7)
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.12] gh-106892: Use roles :data: and :const: for referencing module…
ffc7678 
… variables (GH-106894) (GH-106954)

(cherry picked from commit d036db7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @erlend-aasland
0