10000 gh-106719: Fix __annotations__ getter and setter in the type and module types by serhiy-storchaka · Pull Request #106720 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-106719: Fix __annotations__ getter and setter in the type and module types #106720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

gh-106719: Fix __annotations__ getter and setter in the type and module types #106720

merged 1 commit into from
Jul 18, 2023

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Jul 13, 2023 •
edited by bedevere-bot
Loading

No longer suppress arbitrary errors. Simplify the code.

@serhiy-storchaka
pythongh-106719: Fix __annotations__ getter and setter in the type an…
d64d804 
…d module types

No longer suppress arbitrary errors. Simplify the code.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 13, 2023
Closed
@serhiy-storchaka serhiy-storchaka merged commit e1c295e into python:main Jul 18, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the get_set_annotations branch July 18, 2023 05:57
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e1c295e3da9ff5a3eb6b009a1f821d80e564ac87 3.11

@bedevere-bot
Copy link

GH-106848 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka @miss-islington
pythongh-106719: Fix __annotations__ getter and setter in the type an…
5fab844 
…d module types (pythonGH-106720)

No longer suppress arbitrary errors. Simplify the code.
(cherry picked from commit e1c295e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] pythongh-106719: Fix __annotations__ getter and setter in the …
e976e33 
…type and module types (pythonGH-106720)

No longer suppress arbitrary errors. Simplify the code..
(cherry picked from commit e1c295e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106850 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 18, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-106719: Fix __annotations__ getter and setter in the type a…
d671c65 
…nd module types (GH-106720) (GH-106848)

gh-106719: Fix __annotations__ getter and setter in the type and module types (GH-106720)

No longer suppress arbitrary errors. Simplify the code.
(cherry picked from commit e1c295e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 18, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] gh-106719: Fix __annotations__ getter and setter in the type a…
fb04874 
…nd module types (GH-106720) (GH-106850)

No longer suppress arbitrary errors. Simplify the code.
(cherry picked from commit e1c295e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryhastings larryhastings Awaiting requested review from larryhastings

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot
0