8000 gh-106701: Move the hand-written Tier 2 uops to bytecodes.c by gvanrossum · Pull Request #106702 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-106701: Move the hand-written Tier 2 uops to bytecodes.c #106702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

gh-106701: Move the hand-written Tier 2 uops to bytecodes.c #106702

merged 1 commit into from
Jul 13, 2023

Conversation

gvanrossum
Copy link
Member
@gvanrossum gvanrossum commented Jul 12, 2023 •
edited by bedevere-bot
Loading

This moves EXIT_TRACE, SAVE_IP, JUMP_TO_TOP, and
_POP_JUMP_IF_{FALSE,TRUE} from ceval.c to bytecodes.c.

They are no less special than before,
but this way they are discoverable o the copy-and-patch tooling.

@gvanrossum gvanrossum requested a review from markshannon as a code owner July 12, 2023 22:46
@bedevere-bot bedevere-bot mentioned this pull request Jul 12, 2023
Closed
@gvanrossum gvanrossum requested a review from brandtbucher July 12, 2023 22:46
@gvanrossum
Move the hand-written Tier 2 uops to bytecodes.c
4a4a651 
This moves EXIT_TRACE, SAVE_IP, JUMP_TO_TOP, and
_POP_JUMP_IF_{FALSE,TRUE} from ceval.c to bytecodes.c.

They are no less special than before,
but this way they are discoverable o the copy-and-patch tooling.
@gvanrossum gvanrossum merged commit e6e0ea0 into python:main Jul 13, 2023
@gvanrossum gvanrossum deleted the generate-all-uops branch July 13, 2023 19:14
kgdiem pushed a commit to kgdiem/cpython that referenced this pull request Jul 14, 2023
@gvanrossum @kgdiem
pythongh-106701: Move the hand-written Tier 2 uops to bytecodes.c (py…
ca8147a 
…thon#106702)

This moves EXIT_TRACE, SAVE_IP, JUMP_TO_TOP, and
_POP_JUMP_IF_{FALSE,TRUE} from ceval.c to bytecodes.c.

They are no less special than before, but this way
they are discoverable o the copy-and-patch tooling.
@polynomialherder polynomialherder mentioned this pull request Jul 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvanrossum @bedevere-bot
0