8000 gh-105775: Convert LOAD_CLOSURE to a pseudo-op by polynomialherder · Pull Request #106059 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-105775: Convert LOAD_CLOSURE to a pseudo-op #106059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 29, 2023
Merged

gh-105775: Convert LOAD_CLOSURE to a pseudo-op #106059

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
21d086e
gh-105775: Demote LOAD_CLOSURE to a pseudo-op
polynomialherder Jun 24, 2023
6921930
gh-106044: Fix whitespace
polynomialherder Jun 24, 2023
b111d10
gh-105775: Regenerate generated_cases.c.h
polynomialherder Jun 25, 2023
bbdbb99
Merge branch 'main' into Remove-LOAD-CLOSURE-105775
polynomialherder Jun 25, 2023
93b3138
gh-105775: Add unit test, correct NEWS/docs
polynomialherder Jun 27, 2023
32c1a70
Merge branch 'main' into Remove-LOAD-CLOSURE-105775
polynomialherder Jun 27, 2023
4103b9a
Merge branch 'Remove-LOAD-CLOSURE-105775' of github.com:polynomialher…
polynomialherder Jun 27, 2023
269933e
Merge branch 'main' into Remove-LOAD-CLOSURE-105775
polynomialherder Jun 27, 2023
a069593
Merge branch 'main' into Remove-LOAD-CLOSURE-105775
polynomialherder Jun 27, 2023
988189d
gh-105775: Update documentation, whitespace tweaks
polynomialherder Jun 27, 2023
968601d
Merge branch 'main' into Remove-LOAD-CLOSURE-105775
polynomialherder Jun 27, 2023
46fa9d5
Update news item
polynomialherder Jun 28, 2023
2b677b6
Merge branch 'main' into Remove-LOAD-CLOSURE-105775
polynomialherder Jun 28, 2023
ab8ce45
Merge branch 'main' into Remove-LOAD-CLOSURE-105775
polynomialherder Jun 28, 2023 8000
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-106044: Fix whitespace
  • Loading branch information
@polynomialherder
polynomialherder committed Jun 24, 2023
commit 6921930077d2829f3c252469c6a663285d3874bb
4 changes: 1 addition & 3 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ dummy_func(
// BEGIN BYTECODES //
inst(NOP, (--)) {
}

inst(RESUME, (--)) {
assert(tstate->cframe == &cframe);
assert(frame == cframe.current_frame);
Expand Down Expand Up @@ -192,13 +191,12 @@ dummy_func(
assert(value != NULL);
Py_INCREF(value);
}

inst(LOAD_FAST_AND_CLEAR, (-- value)) {
value = GETLOCAL(oparg);
// do not use SETLOCAL here, it decrefs the old value
GETLOCAL(oparg) = NULL;
}

inst(LOAD_FAST_LOAD_FAST, ( -- value1, value2)) {
uint32_t oparg1 = oparg >> 4;
uint32_t oparg2 = oparg & 15;
Expand Down
1 change: 0 additions & 1 deletion Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,6 @@ stack_effect(int opcode, int oparg, int jump)
* of __(a)enter__ and push 2 values before jumping to the handler
* if an exception be raised. */
return jump ? 1 : 0;

case STORE_FAST_MAYBE_NULL:
return -1;
case LOAD_CLOSURE:
Expand Down
0