8000 More reorganisation of the typing docs by AlexWaygood · Pull Request #105787 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

More reorganisation of the typing docs #105787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

More reorganisation of the typing docs #105787

merged 1 commit into from
Jun 15, 2023

Conversation

AlexWaygood
Copy link
Member
@AlexWaygood AlexWaygood commented Jun 14, 2023 •
edited by github-actions bot
Loading
  1. Merge the "Generic Concrete Collections" and "Abstract Base classes" sections into a "Deprecated Aliases" section. Rename that section and the subsections inside it to better reflect the fact that all items within the "Deprecated aliases" section are deprecated. Add anchors so that the old links will still work, if people are linking to subsections from external sites.
  2. Move the "async-ABC aliases" section above the "misc-ABC aliases" section. "Aliases to container ABCs from collections.abc; aliases to async ABCs from collections.abc; and aliases to other ABCs from collections.abc" reads more naturally than "Aliases to container ABCs from collections.abc; aliases to other ABCs from collections.abc; and aliases to async ABCs from collections.abc".
  3. Move typing.IO, typing.TextIO and typing.BinaryIO to their own section. They are currently the only items in the "Generic concrete collections" and "Abstract Base Classes" sections that aren't deprecated.

📚 Documentation preview 📚: https://cpython-previews--105787.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jun 14, 2023
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 14, 2023
CAM-Gerlach
CAM-Gerlach approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member
@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective 👍

@AlexWaygood AlexWaygood merged commit da911a6 into python:main Jun 15, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@AlexWaygood AlexWaygood deleted the typing-docs-reorg branch June 15, 2023 05:52
@miss-islington
Copy link
Contributor

Sorry @AlexWaygood, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker da911a6b226ca47cc15088d800b575e19a731f1c 3.12

@miss-islington
Copy link
Contributor

Sorry, @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da911a6b226ca47cc15088d800b575e19a731f1c 3.11

@AlexWaygood AlexWaygood added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 15, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @AlexWaygood, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker da911a6b226ca47cc15088d800b575e19a731f1c 3.12

@AlexWaygood AlexWaygood added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 15, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖