8000 gh-104909: Implement conditional stack effects for macros by gvanrossum · Pull Request #105748 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-104909: Implement conditional stack effects for macros #105748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 14, 2023
Merged

gh-104909: Implement conditional stack effects for macros #105748

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4291adf
Fix types and bug for pseudos
gvanrossum Jun 12, 2023
eee069c
Example: macrofy _LOAD_GLOBAL_BUILTIN
gvanrossum Jun 13, 2023
3bb5557
Fix conditional stack output effect metadata
gvanrossum Jun 13, 2023
035d13b
Attempt adding conditionals to mac.stack
gvanrossum Jun 13, 2023
c4b88a9
Fix macros with conditional output effect
gvanrossum Jun 13, 2023
457e501
Revert "Example: macrofy _LOAD_GLOBAL_BUILTIN"
gvanrossum Jun 13, 2023
dec34ef
Regenerate after reverting example
gvanrossum Jun 13, 2023
b82c4b8
Merge remote-tracking branch 'origin/main' into cond-effect-2
gvanrossum Jun 13, 2023
63e498e
Rename unconditional to init_null (with reverted sense)
gvanrossum Jun 13, 2023
f9e11e0
Add test; fix stack effect bug
gvanrossum Jun 14, 2023
958e9f1
Merge branch 'main' into cond-effect-2
gvanrossum Jun 14, 2023
fb905d7
Make the test more thorough
gvanrossum Jun 14, 2023
846a161
Better way to solve the 'init_null' problem
gvanrossum Jun 14, 2023
3551576
Merge branch 'main' into cond-effect-2
gvanrossum Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix conditional stack output effect metadata
  • Loading branch information
@gvanrossum
gvanrossum committed Jun 13, 2023
commit 3bb5557250ac7a64eb773d07340227ff5b970603
7 changes: 5 additions & 2 deletions Tools/cases_generator/generate_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,15 +881,17 @@ def effect_str(effects: list[StackEffect]) -> str:
low = 0
sp = 0
high = 0
pushed_symbolic: list[str] = []
for comp in parts:
for effect in comp.instr.input_effects:
assert not effect.cond, effect
assert not effect.size, effect
sp -= 1
low = min(low, sp)
for effect in comp.instr.output_effects:
assert not effect.cond, effect
assert not effect.size, effect
if effect.cond:
pushed_symbolic.append(maybe_parenthesize(f"{maybe_parenthesize(effect.cond)} ? 1 : 0"))
sp += 1
high = max(sp, high)
if high != max(0, sp):
Expand All @@ -899,7 +901,8 @@ def effect_str(effects: list[StackEffect]) -> str:
# calculations to use the micro ops.
self.error("Macro has virtual stack growth", thing)
popped = str(-low)
pushed = str(sp - low)
pushed_symbolic.append(str(sp - low - len(pushed_symbolic)))
pushed = " + ".join(pushed_symbolic)
case parser.Pseudo():
instr = self.pseudo_instrs[thing.name]
popped = pushed = None
Expand Down
0