8000 bpo-35202: Remove more unused imports in idlelib by srinivasreddy · Pull Request #10573 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-35202: Remove more unused imports in idlelib #10573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2018
Merged

bpo-35202: Remove more unused imports in idlelib #10573

merged 1 commit into from
Nov 17, 2018

Conversation

srinivasreddy
Copy link
Contributor
@srinivasreddy srinivasreddy commented Nov 16, 2018 •
edited by bedevere-bot
Loading

@srinivasreddy
Copy link
Contributor Author

@terryjreedy Requesting review since it is idlelib

@terryjreedy terryjreedy self-assigned this Nov 17, 2018
@terryjreedy
Copy link
Member

This is covered by the previous news entry for idlelib on the same issue.

@terryjreedy terryjreedy changed the title bpo-35202: Remove unused imports bpo-35202: Remove more unused imports in idlelib Nov 17, 2018
@terryjreedy terryjreedy merged commit 5a087d5 into python:master Nov 17, 2018
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2018
@srinivasreddy @miss-islington
bpo-35202: Remove more unused imports in idlelib (pythonGH-10573)
766a7bd 
(cherry picked from commit 5a087d5)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@bedevere-bot
Copy link

GH-10582 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-10583 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2018
@srinivasreddy @miss-islington
bpo-35202: Remove more unused imports in idlelib (pythonGH-10573)
d3055f1 
(cherry picked from commit 5a087d5)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL 3.x has failed when building commit 5a087d5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/21/builds/1902) and take a look at the build logs.
  4. Check if the failure is related to this commit (5a087d5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/21/builds/1902

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': Failed connect to github.com:443; Connection refused

make: *** No rule to make target `distclean'.  Stop.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.x has failed when building commit 5a087d5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/16/builds/1881) and take a look at the build logs.
  4. Check if the failure is related to this commit (5a087d5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/16/bui 8000 lds/1881

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': Failed to connect to github.com port 443: Connection refused

make: *** No rule to make target 'distclean'.  Stop.

miss-islington added a commit that referenced this pull request Nov 17, 2018
@miss-islington @srinivasreddy
bpo-35202: Remove more unused imports in idlelib (GH-10573)
3a600d2 
(cherry picked from commit 5a087d5)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington added a commit that referenced this pull request Nov 17, 2018
@miss-islington @srinivasreddy
bpo-35202: Remove more unused imports in idlelib (GH-10573)
8d816f7 
(cherry picked from commit 5a087d5)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL 3.7 has failed when building commit 3a600d2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/126/builds/783) and take a look at the build logs.
  4. Check if the failure is related to this commit (3a600d2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/126/builds/783

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-rhel-z/build/Lib/test/test_robotparser.py", line 351, in test_read_404
    self.assertTrue(parser.allow_all)
AssertionError: False is not true

----------------------------------------------------------------------

Ran 40 tests in 0.047s

FAILED (failures=1)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-rhel-z/build/Lib/test/test_urllibnet.py", line 101, in test_getcode
    self.assertEqual(code, 404)
AssertionError: 503 != 404

----------------------------------------------------------------------

Ran 12 tests in 5.097s

FAILED (failures=1, skipped=1)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-rhel-z/build/Lib/test/test_robotparser.py", line 351, in test_read_404
    self.assertTrue(parser.allow_all)
AssertionError: False is not true

----------------------------------------------------------------------

Ran 40 tests in 0.039s

FAILED (failures=1)
Re-running test 'test_urllibnet' in verbose mode


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.7.edelsohn-rhel-z/build/Lib/test/test_urllibnet.py", line 101, in test_getcode
    self.assertEqual(code, 404)
AssertionError: 503 != 404

----------------------------------------------------------------------

Ran 12 tests in 5.086s

FAILED (failures=1, skipped=1)

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.6 has failed when building commit 8d816f7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/63/builds/726) and take a look at the build logs.
  4. Check if the failure is related to this commit (8d816f7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/63/builds/726

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': Failed to connect to github.com port 443: Connection refused

make: *** No rule to make target 'distclean'.  Stop.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL 3.6 has failed when building commit 8d816f7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/29/builds/703) and take a look at the build logs.
  4. Check if the failure is related to this commit (8d816f7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/29/builds/703

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.6.edelsohn-rhel-z/build/Lib/test/test_robotparser.py", line 355, in test_read_404
    self.assertTrue(parser.allow_all)
AssertionError: False is not true

----------------------------------------------------------------------

Ran 40 tests in 0.048s

FAILED (failures=1)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.6.edelsohn-rhel-z/build/Lib/test/test_urllibnet.py", line 101, in test_getcode
    self.assertEqual(code, 404)
AssertionError: 503 != 404

----------------------------------------------------------------------

Ran 12 tests in 5.091s

FAILED (failures=1, skipped=1)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.6.edelsohn-rhel-z/build/Lib/test/test_robotparser.py", line 355, in test_read_404
    self.assertTrue(parser.allow_all)
AssertionError: False is not true

----------------------------------------------------------------------

Ran 40 tests in 0.051s

FAILED (failures=1)
Re-running test 'test_urllibnet' in verbose mode


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.6.edelsohn-rhel-z/build/Lib/test/test_urllibnet.py", line 101, in test_getcode
    self.assertEqual(code, 404)
AssertionError: 503 != 404

----------------------------------------------------------------------

Ran 12 tests in 5.080s

FAILED (failures=1, skipped=1)

@pablogsal
Copy link
Member

These buildbots had a connectivity problem, all these are false positives.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Windows7 3.6 has failed when building commit 8d816f7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/90/builds/672) and take a look at the build logs.
  4. Check if the failure is related to this commit (8d816f7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/90/builds/672

Click to see traceback logs 
From https://github.com/python/cpython
 * branch            3.6        -> FETCH_HEAD
Reset branch '3.6'

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\PCbuild\python*.zip
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.

test_ioctl skipped -- No module named 'fcntl'
test_devpoll skipped -- test works only on Solaris OS family
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
minkernel\crts\ucrt\src\appcrt\lowio\close.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_dbm_ndbm skipped -- No module named '_dbm'
test_dbm_gnu skipped -- No module named '_gdbm'
test_crypt skipped -- No module named '_crypt'
test_kqueue skipped -- test works only on BSD
test_readline skipped -- No module named 'readline'
test_syslog skipped -- No module named 'syslog'
test_pty skipped -- No module named 'termios'
test_pwd skipped -- No module named 'pwd'
test_grp skipped -- No module named 'grp'
test_resource skipped -- No module named 'resource'
test_pipes skipped -- pipes module only works on posix
test_poll skipped -- select.poll not defined
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_wait3 skipped -- os.fork not defined
minkernel\crts\ucrt\src\appcrt\lowio\write.cpp(49) : Assertion failed: (_osfile(fh) & FOPEN)
test_threadsignals skipped -- Can't test signal on win32
test_fork1 skipped -- object <module 'os' from 'D:\\cygwin\\home\\db3l\\buildarea\\3.6.bolen-windows7\\build\\lib\\os.py'> has no attribute 'fork'
test_curses skipped -- No module named '_curses'
test_ossaudiodev skipped -- No module named 'ossaudiodev'
Timeout (0:15:00)!
Thread 0x00000f4c (most recent call first):
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\threading.py", line 295 in wait
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\queues.py", line 222 in _feed
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\threading.py", line 864 in run
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\threading.py", line 916 in _bootstrap_inner
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\threading.py", line 884 in _bootstrap

Thread 0x00000cf4 (most recent call first):
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\synchronize.py", line 261 in wait
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\queues.py", line 305 in join
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\_test_multiprocessing.py", line 850 in test_task_done
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\case.py", line 605 in run
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\case.py", line 653 in __call__
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\suite.py", line 122 in run
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\suite.py", line 84 in __call__
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\suite.py", line 122 in run
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\suite.py", line 84 in __call__
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\suite.py", line 122 in run
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\suite.py", line 84 in __call__
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\unittest\runner.py", line 176 in run
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\support\__init__.py", line 1914 in _run_suite
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\support\__init__.py", line 2008 in run_unittest
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\libregrtest\runtest.py", line 175 in test_runner
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\libregrtest\runtest.py", line 179 in runtest_inner
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\libregrtest\runtest.py", line 124 in runtest
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\libregrtest\runtest_mp.py", line 72 in run_tests_slave
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\libregrtest\main.py", line 587 in _main
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\libregrtest\main.py", line 571 in main
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\libregrtest\main.py", line 627 in main
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\regrtest.py", line 46 in _main
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\regrtest.py", line 50 in <module>
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\runpy.py", line 85 in _run_code
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\runpy.py", line 193 in _run_module_as_main
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\spawn.py", line 99, in spawn_main
    new_handle = reduction.steal_handle(parent_pid, pipe_handle)
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\reduction.py", line 87, in steal_handle
    _winapi.DUPLICATE_SAME_ACCESS | _winapi.DUPLICATE_CLOSE_SOURCE)
PermissionError: [WinError 5] Access is denied
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\spawn.py", line 99, in spawn_main
    new_handle = reduction.steal_handle(parent_pid, pipe_handle)
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\reduction.py", line 87, in steal_handle
    _winapi.DUPLICATE_SAME_ACCESS | _winapi.DUPLICATE_CLOSE_SOURCE)
PermissionError: [WinError 5] Access is denied
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\spawn.py", line 99, in spawn_main
    new_handle = reduction.steal_handle(parent_pid, pipe_handle)
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\reduction.py", line 87, in steal_handle
    _winapi.DUPLICATE_SAME_ACCESS | _winapi.DUPLICATE_CLOSE_SOURCE)
PermissionError: [WinError 5] Access is denied
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\spawn.py", line 99, in spawn_main
    new_handle = reduction.steal_handle(parent_pid, pipe_handle)
  File "D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\multiprocessing\reduction.py", line 87, in steal_handle
    _winapi.DUPLICATE_SAME_ACCESS | _winapi.DUPLICATE_CLOSE_SOURCE)
PermissionError: [WinError 5] Access is denied
test_posix skipped -- No module named 'posix'
test_epoll skipped -- test works only on Linux 2.6
test_wait4 skipped -- object <module 'os' from 'D:\\cygwin\\home\\db3l\\buildarea\\3.6.bolen-windows7\\build\\lib\\os.py'> has no attribute 'fork'
test_spwd skipped -- No module named 'spwd'
test_fcntl skipped -- No module named 'fcntl'
test_gdb skipped -- Couldn't find gdb on the path
test_nis skipped -- No module named 'nis'
test_openpty skipped -- os.openpty() not available.
stty: standard input: Inappropriate ioctl for device
D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\lib\test\support\__init__.py:1029: RuntimeWarning: tests may fail, unable to create temp dir: D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\build\test_python_3492
  with temp_dir(path=name, quiet=quiet) as temp_path:
test test_multiprocessing_spawn failed

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.6.bolen-windows7\build\PCbuild\python*.zip

@srinivasreddy srinivasreddy deleted the rm_imports_35202 branch November 17, 2018 11:09
@terryjreedy
Copy link
Member

@pablogsal @vstinner To me, splattering a PR and participants' mailboxes with such (false) reports is pretty obnoxious. With our current CI, perhaps 99% of such reports that I would see, and this is not the first, will be false.

It seems to me that test failure reports should be sent to the person or persons responsible for the failing test. If test_idle fails, I should be informed regardless of which PR triggered the test run.

It seems to me that connection failures should be reported to the buildbot owner. Or the tests that depend on external connections should be skipped when the connection fails.

@pablogsal
Copy link
Member
pablogsal commented Nov 17, 2018 •
edited
Loading

@terryjreedy One reason why we started reporting here is precisely to raise awareness when the buildbots are broken. Having a failing test persisting in the buildbots is a cascading effect and debugging and fixing those is much more difficult. For this reason there is the rule of reverting Pull Requests if there is not a fix in less than a couple of hours.

IMHO if there are false positives (normally due to race conditions and similar) the correct thing is fixing the test suite, not muting the reporting system. Right now there are very few people subscribed to the buildbot failure mailing list and reporting in the PR was proposed by multiple core developers as an improvement to help people understand when there is a buildbot failing.

We receive the real failures and the false positives in the mailing list and we need to triage all of them. This notification system helps notifying people of such failures, including the core dev that merged the PR and the author and since then we have much more general collaboration from everyone triaging and fixing tests, which I would say is a great improvement compared with the previous situation. @vstinner can provide more details on how taxing and hard was (and still is) watching the buildbots.

Additionally, there have been multiple cases of real failures fixed really fast thanks to reporting in the Pull Request. I understand that it can be noisy, but I would say again that we should not suppress the notification system and fix the bugs instead. On the other hand this is exactly as noisy as the buildbot failure mailing list, with the exception that only the people involved in the PR are notified (in addition to us that watch the mailing list).

@terryjreedy
Copy link
Member

Pablo, I already understood the rationale. What I said above is that the implementation is so faulty from my viewpoint that it is pointless for me to pay any attention to these reports.
6D47

@pablogsal
Copy link
Member
pablogsal commented Nov 18, 2018 •
edited
Loading

@terryjreedy Oh, I understand. The problem is that the buildbot report system extensions makes very difficult to improve the implementation. For example, there is no way other than parsing stdout to even know which test failed. It may be possible to use junit files or similar approaches but a lot more infrastructure would be needed. I can try to spend some time in the future to improve the situation, what parts of the implementation do you found faulty?

IMHO the biggest problem is the present of false positives in general. I look every failure reported by any buildbot to triage them in case there are real positives. More than 60% of all emails I triage are false positives for the commit that is being built and as you can imagine I spend a lot of time doing this process. Sadly we cannot just stop looking at the reports because real failures will pass inadvertently and will cascade when there are multiple ones. Is a very hard problem to solve :(

@vstinner
Copy link
Member

@terryjreedy Taking care of the CI is the duty of all core developers. Flaky tests are common. The purpose of annoying enough developers is that some day, one will show up and propose a fix :-)

@vstinner
Copy link
Member

https://buildbot.python.org/all/#builders/21/builds/1902

"fatal: unable to access 'https://github.com/python/cpython.git/': Failed connect to github.com:443; Connection refused"

This is bug in the CI which exists for years, but nobody found any solution yet. @terryjreedy: do you have an idea how to fix this exact bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srinivasreddy @terryjreedy @miss-islington @bedevere-bot @pablogsal @vstinner @the-knights-who-say-ni
0