8000 gh-105140: remove unused arg of _PyErr_ChainStackItem by iritkatriel · Pull Request #105141 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-105140: remove unused arg of _PyErr_ChainStackItem #105141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2023
Merged

gh-105140: remove unused arg of _PyErr_ChainStackItem #105141

merged 4 commits into from
Jun 1, 2023

Conversation

iritkatriel
Copy link
Member
@iritkatriel iritkatriel commented May 31, 2023 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel requested a review from markshannon as a code owner May 31, 2023 12:55
@bedevere-bot bedevere-bot mentioned this pull request May 31, 2023
Closed
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 31, 2023
@iritkatriel iritkatriel requested a review from vstinner June 1, 2023 18:31
vstinner
vstinner approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since tests still pass and i'm confident that gen_send_ex2() is tested by the Python test suite.

Misc/NEWS.d/next/Core and Builtins/2023-05-31-13-54-41.gh-issue-105140.JmPdPc.rst Outdated
@@ -0,0 +1 @@
Remove unused, untested and undocumented arg of ``_PyErr_ChainStackItem``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that end users care about changes in the internal C API. You can remove this NEWS entry.

@iritkatriel iritkatriel enabled auto-merge (squash) June 1, 2023 20:25
@iritkatriel iritkatriel merged commit 60f8117 into python:main Jun 1, 2023
@iritkatriel iritkatriel deleted the _PyErr_ChainStackItem branch July 25, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner 6284 vstinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove unused argument of _PyErr_ChainStackItem
3 participants
@iritkatriel @vstinner @bedevere-bot
0