8000 gh-96471: Add threading queue shutdown by EpicWink · Pull Request #104750 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-96471: Add threading queue shutdown #104750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 10, 2024
Merged

gh-96471: Add threading queue shutdown #104750

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cd8ceaf
Add threading queue shutdown
EpicWink Sep 1, 2022
9c2971b
Fix queue shutdown
YvesDup Feb 10, 2023
089eb96
📜🤖 Added by blurb_it.
blurb-it[bot] May 6, 2023
ca118d7
Shut-down immediate consumes queue
EpicWink May 22, 2023
88f918d
Update test typing
EpicWink Dec 8, 2023
ab8d975
Remove queue-size tasks instead of setting to zero
EpicWink Feb 5, 2024
f279f5c
Merge remote-tracking branch 'upstream/main' into threading-queue-shu…
EpicWink Feb 8, 2024
971f699
Improve doc wording, reference methods
EpicWink Feb 8, 2024
ddfb8c2
Reference method in news entry
EpicWink Feb 8, 2024
3570bd8
Remove typing in test script
EpicWink Feb 8, 2024
9072c6f
Fix join after task-done with no get
EpicWink Feb 8, 2024
e0927aa
More explicitly update 'q.unfinished_tasks'
EpicWink Feb 9, 2024
22adada
Add what's new entry
EpicWink Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove typing in test script
  • Loading branch information
@EpicWink
EpicWink committed Feb 8, 2024
commit 3570bd8f2bd5fb2a150e856086eedd208dd111db
20 changes: 2 additions & 18 deletions Lib/test/test_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@
from test.support import import_helper
from test.support import threading_helper

import typing as t

if t.TYPE_CHECKING:
import queue

parent_class = unittest.TestCase

else:
parent_class = object

# queue module depends on threading primitives
threading_helper.requires_working_threading(module=True)

Expand Down Expand Up @@ -65,10 +55,7 @@ def run(self):
# is supposed to raise an exception, call do_exceptional_blocking_test()
# instead.

class BlockingTestMixin(parent_class):
if t.TYPE_CHECKING:
queue = queue
type2test: t.Type[queue.Queue]
class BlockingTestMixin:

def do_blocking_test(self, block_func, block_args, trigger_func, trigger_args):
thread = _TriggerThread(trigger_func, trigger_args)
Expand Down Expand Up @@ -810,10 +797,7 @@ class CFailingQueueTest(FailingQueueTest, unittest.TestCase):
queue = c_queue


class BaseSimpleQueueTest(parent_class):
if t.TYPE_CHECKING:
queue = queue
type2test: t.Type[queue.Queue]
class BaseSimpleQueueTest:

def setUp(self):
self.q = self.type2test()
Expand Down
0