8000 gh-104050: Add typing to Argument Clinic converters by erlend-aasland · Pull Request #104547 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-104050: Add typing to Argument Clinic converters #104547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2023
Merged

gh-104050: Add typing to Argument Clinic converters #104547

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cce842a
gh-104050: Add typing to Argument Clinic converters
erlend-aasland May 16, 2023
8191183
Update Tools/clinic/clinic.py
erlend-aasland May 16, 2023
dd1c773
Also add types to 'default_type'
erlend-aasland May 16, 2023
bdc130d
Remove annotations of simple assignments
erlend-aasland May 16, 2023
75cb81e
Merge branch 'main' into typed-clinic/converters
AlexWaygood May 16, 2023
2e5b92c
Address reviews
erlend-aasland May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address reviews
  • Loading branch information
@erlend-aasland
erlend-aasland committed May 16, 2023
commit 2e5b92c7acdb9c33ad4526f195fb37bdce1e88fa
4 changes: 2 additions & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2943,7 +2943,7 @@ def parse_arg(self, argname, displayname):
""".format(argname=argname, paramname=self.parser_name, cast=cast)
return None

def set_template_dict(self, template_dict: TemplateDict):
def set_template_dict(self, template_dict: TemplateDict) -> None:
pass

@property
Expand Down Expand Up @@ -3074,7 +3074,7 @@ class unsigned_char_converter(CConverter):
format_unit = 'b'
c_ignored_default = "'\0'"

def converter_init(self, *, bitwise=False) -> None:
def converter_init(self, *, bitwise: bool = False) -> None:
if bitwise:
self.format_unit = 'B'

Expand Down
0