-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-104050: Run mypy on clinic.py
in CI
#104421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ca8532b
Slightly annotate cpp.py
erlend-aasland d2ec2ef
Slightly annotate clinic.py
erlend-aasland 801af38
Address review
erlend-aasland 00183ff
Add basic mypy workflow to CI
AlexWaygood 4bdd409
Make the type check pass
AlexWaygood 632843b
Tweak workflow file
AlexWaygood f7e7a25
improve workflow file
AlexWaygood 510e08b
Add some more return annotations
AlexWaygood 773c2ba
simpler glob
AlexWaygood 6c7ecb9
Address various reviews!
AlexWaygood 717ee47
more from Hugo
AlexWaygood 62669d1
Fix ini syntax
AlexWaygood ddd0843
Unused import
AlexWaygood b7158db
Merge branch 'main' into clinic-mypy-check
AlexWaygood 9fcd87f
Restore c
8000
ompatibility with Python 3.8
AlexWaygood 010f0dd
Revert "Restore compatibility with Python 3.8"
AlexWaygood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Revert "Restore compatibility with Python 3.8"
This reverts commit 9fcd87f.
- Loading branch information
commit 010f0dd313f36d34f2a0e52659e20a44e117efc8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I usually put my mypy config in a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.