8000 gh-104223: Fix issues with inheriting from buffer classes by JelleZijlstra · Pull Request #104227 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-104223: Fix issues with inheriting from buffer classes #104227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 8, 2023
Merged

gh-104223: Fix issues with inheriting from buffer classes #104227

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b7fb7a4
Fix buffer classes using super()
JelleZijlstra May 6, 2023
c717784
Fix bf_releasebuffer in child classes
JelleZijlstra May 6, 2023
9fcb214
Merge branch 'main' into pep688fix
JelleZijlstra May 6, 2023
88ce24d
Add a test
JelleZijlstra May 6, 2023
80a4b0b
Deal with __release_buffer__ saving references to the buffer
JelleZijlstra May 7, 2023
6e31664
Add another test
JelleZijlstra May 7, 2023
b73e29c
More paranoid bufferwrapper_releasebuf
JelleZijlstra May 7, 2023
15ad02d
that did not work
JelleZijlstra May 7, 2023
9ded873
Update Objects/typeobject.c
JelleZijlstra May 7, 2023
3b50138
Update Objects/typeobject.c
JelleZijlstra May 7, 2023
056efee
Merge remote-tracking branch 'upstream/main' into pep688fix
JelleZijlstra May 7, 2023
9ee8eb5
Better message for new flag
JelleZijlstra May 7, 2023
5536853
More tests
JelleZijlstra May 7, 2023
02d7b9c
Merge branch 'main' into pep688fix
JelleZijlstra May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed May 6, 2023
commit 88ce24da3d15e86177cb6e710331382a21b28960
30 changes: 30 additions & 0 deletions Lib/test/test_buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4604,6 +4604,36 @@ def __release_buffer__(self, view):
self.assertEqual(rb_call_count, 0)
self.assertEqual(rb_call_count, 1)

def test_inherit_but_return_something_else(self):
class A(bytearray):
def __buffer__(self, flags):
return memoryview(b"hello")

a = A(b"hello")
with memoryview(a) as mv:
self.assertEqual(mv.tobytes(), b"hello")

rb_call_count = 0
rb_raised = False
class B(bytearray):
def __buffer__(self, flags):
return memoryview(b"hello")
def __release_buffer__(self, view):
nonlocal rb_call_count
rb_call_count += 1
try:
super().__release_buffer__(view)
except ValueError:
nonlocal rb_raised
rb_raised = True

b = B(b"hello")
with memoryview(b) as mv:
self.assertEqual(mv.tobytes(), b"hello")
self.assertEqual(rb_call_count, 0)
self.assertEqual(rb_call_count, 1)
self.assertIs(rb_raised, True)


if __name__ == "__main__":
unittest.main()
0