8000 [3.11] gh-96670: Raise SyntaxError when parsing NULL bytes (GH-97594) by lysnikolaou · Pull Request #104195 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.11] gh-96670: Raise SyntaxError when parsing NULL bytes (GH-97594) #104195

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2023
Merged

[3.11] gh-96670: Raise SyntaxError when parsing NULL bytes (GH-97594) #104195

merged 3 commits into from
May 7, 2023

Conversation

lysnikolaou
Copy link
Member
@lysnikolaou lysnikolaou commented May 5, 2023 •
edited
Loading

@lysnikolaou @pablogsal
[3.11] pythongh-96670: Raise SyntaxError when parsing NULL bytes (pyt…
e6d28ba 
…honGH-97594).

(cherry picked from commit aab01e3)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
This was referenced May 5, 2023
Closed
Merged
@lysnikolaou
Copy link
Member Author

@pablogsal I'm not sure what to do with the NEWS file from your original PR. Leave it as-is and include it here, skip it or write a new one with something like "Backporting to 3.11"?

@lysnikolaou lysnikolaou mentioned this pull request May 5, 2023
Merged
@pablogsal
Copy link
Member

@pablogsal I'm not sure what to do with the NEWS file from your original PR. Leave it as-is and include it here, skip it or write a new one with something like "Backporting to 3.11"?

I would leave it the same and maybe add at the end (backported from ...)

@lysnikolaou
Copy link
Member Author

I would leave it the same and maybe add at the end (backported from ...)

Done! Thanks for the help!

@lysnikolaou lysnikolaou force-pushed the backport-aab01e3-3.11 branch from f0c0f22 to de5f0b3 Compare May 5, 2023 18:23
@pablogsal pablogsal merged commit a09d390 into python:3.11 May 7, 2023
@vEpiphyte vEpiphyte mentioned this pull request Jun 7, 2023
Merged
The-Compiler added a commit to qutebrowser/qutebrowser that referenced this pull request Jun 9, 2023
@The-Compiler
test: Adjust test_nul_bytes version check
8b05838 
Python 3.11.4 also got the fix backported which turns this into a SyntaxError:
python/cpython#104195
This was referenced Nov 4, 2023
Closed
Closed
@devdanzin devdanzin mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lysnikolaou @pablogsal @bedevere-bot
0