-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly #104140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5397cd9
gh-NNNN: Skip scheduling a done callback if a TaskGroup task complete…
itamaro 8d6a77e
Add NEWS entry
itamaro a125c1f
Apply review feedback to NEWS entry
itamaro dae3e06
Merge branch 'main' into taskgroups-skip-done-callback
itamaro 161d0f8
revert skipping _set_task_name if name is None; fix typo in comment
itamaro 2b98bd9
Merge branch 'main' into taskgroups-skip-done-callback
itamaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add NEWS entry
- Loading branch information
commit 8d6a77e8c312bb1cbdaaca2f316897412fce4da3
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2023-05-03-16-51-53.gh-issue-104144.653Q0P.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Optimize asyncio.TaskGroup when using eager tasks factory -- Skip scheduling | ||
done callbacks when all tasks finish without blocking - for up to 4x speedup | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.