8000 bpo-34011: Fix the construction of subprocess.CalledProcessError in test_venv by pablogsal · Pull Request #10400 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-34011: Fix the construction of subprocess.CalledProcessError in test_venv #10400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

bpo-34011: Fix the construction of subprocess.CalledProcessError in test_venv #10400

merged 1 commit into from
Nov 7, 2018

Conversation

pablogsal
Copy link
Member
@pablogsal pablogsal commented Nov 7, 2018 •
edited by bedevere-bot
Loading

@pablogsal pablogsal self-assigned this Nov 7, 2018
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Nov 7, 2018
@pablogsal pablogsal merged commit b939250 into python:master Nov 7, 2018
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the bpo34011 branch November 7, 2018 22:21
@bedevere-bot
Copy link

GH-10401 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
@pablogsal @miss-islington
Fix the construction of subprocess.CalledProcessError in test_venv (p…
da59fad 
…ythonGH-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
@pablogsal @miss-islington
Fix the construction of subprocess.CalledProcessError in test_venv (p…
ddb9f75 
…ythonGH-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-10402 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Nov 7, 2018
@miss-islington @pablogsal
Fix the construction of subprocess.CalledProcessError in test_venv (G…
b097f9f 
…H-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Nov 7, 2018
@miss-islington @pablogsal
Fix the construction of subprocess.CalledProcessError in test_venv (G…
0e39836 
…H-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pablogsal pablogsal

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni
0