8000 gh-88773: Added teleport method to Turtle library by liam-gersten · Pull Request #103974 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-88773: Added teleport method to Turtle library #103974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 30, 2023
Merged

gh-88773: Added teleport method to Turtle library #103974

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a51d835
Working teleport method
liam-gersten Apr 27, 2023
7986926
Handle filling with teleport method
liam-gersten Apr 28, 2023
1054b34
Teleport method documentation
liam-gersten Apr 28, 2023
af7c1c6
Merge branch 'main' into TurtleTeleportMethod
liam-gersten Apr 28, 2023
5871c2c
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 28, 2023
494f478
Fixed NEWS entry
liam-gersten Apr 28, 2023
2fd8eda
Update Misc/NEWS.d/next/Library/2023-04-28-18-04-23.gh-issue-88773.xX…
terryjreedy Apr 28, 2023
e89549e
Merge branch 'main' into TurtleTeleportMethod
liam-gersten Apr 28, 2023
ba2920e
Made new coord assignment more concise
liam-gersten Apr 28, 2023
01dd697
Merge branch 'TurtleTeleportMethod' of https://github.com/liam-gerste…
liam-gersten Apr 28, 2023
f8a9681
Teleport documentation in Doc/library/turtle.rst
liam-gersten Apr 28, 2023
7cec9b6
Update Doc/library/turtle.rst
liam-gersten Apr 28, 2023
eec5411
Update Misc/NEWS.d/next/Library/2023-04-28-18-04-23.gh-issue-88773.xX…
liam-gersten Apr 28, 2023
ca3d9c5
Partial teleport method in TNavigator for testing in TestTNavigator
liam-gersten Apr 28, 2023
02712b3
Partial teleport method in TPen for testing in TestTPen
liam-gersten Apr 28, 2023
8db9bf3
Teleport tests in TestTNavigator and TestTPen
liam-gersten Apr 28, 2023
4272101
Merge branch 'main' into TurtleTeleportMethod
8000 liam-gersten Apr 28, 2023
ae01a3e
Made teleport appear in alphabetical order
liam-gersten Apr 28, 2023
43f8a69
Merge branch 'TurtleTeleportMethod' of https://github.com/liam-gerste…
liam-gersten Apr 28, 2023
07ae3da
Attempt to fix the doctests.
gpshead Apr 29, 2023
d648f52
Mention fill_gap in the teleport prototype.
gpshead Apr 29, 2023
2baaf85
Make fill_gap a keyword only argument.
gpshead Apr 29, 2023
203a0f3
Align docs with fill_gap being keyword only.
gpshead Apr 29, 2023
dac054e
Testing changes for fill_gap arg and assertFalse
liam-gersten Apr 30, 2023
9a38e8a
Merge branch 'main' into TurtleTeleportMethod
liam-gersten Apr 30, 2023
fc880c8
Merge branch 'main' into TurtleTeleportMethod
liam-gersten Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make fill_gap a keyword only argument.
  • Loading branch information
@gpshead
gpshead committed Apr 29, 2023
commit 2baaf85255cf1a85b93935e8807c3cfe6437fb64
10 changes: 5 additions & 5 deletions Lib/turtle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,7 +1614,7 @@ def _goto(self, end):
"""move turtle to position end."""
self._position = end

def teleport(self, x=None, y=None, fill_gap: bool = False) -> None:
def teleport(self, x=None, y=None, *, fill_gap: bool = False) -> None:
"""To be overwritten by child class RawTurtle.
Includes no TPen references."""
new_x = x if x is not None else self._position[0]
Expand Down Expand Up @@ -2300,7 +2300,7 @@ def fillcolor(self, *args):
else:
return self._color(self._fillcolor)

def teleport(self, x=None, y=None, fill_gap: bool = False) -> None:
def teleport(self, x=None, y=None, *, fill_gap: bool = False) -> None:
"""To be overwritten by child class RawTurtle.
Includes no TNavigator references.
"""
Expand Down Expand Up @@ -2727,13 +2727,13 @@ def _cc(self, args):
raise TurtleGraphicsError("bad color sequence: %s" % str(args))
return "#%02x%02x%02x" % (r, g, b)

def teleport(self, x=None, y=None, fill_gap: bool = False) -> None:
def teleport(self, x=None, y=None, *, fill_gap: bool = False) -> None:
"""Instantly move turtle to an absolute position.

Arguments:
x -- a number or None
y -- a number None
fill_gap -- a boolean None
fill_gap -- a boolean This argument must be specified by name.

call: teleport(x, y) # two coordinates
--or: teleport(x) # teleport to x position, keeping y as is
Expand All @@ -2751,7 +2751,7 @@ def teleport(self, x=None, y=None, fill_gap: bool = False) -> None:
Example (for a Turtle instance named turtle):
>>> tp = turtle.pos()
>>> tp
(0.00, 0.00)
(0.00,0.00)
>>> turtle.teleport(60)
>>> turtle.pos()
(60.00,0.00)
Expand Down
0