gh-103395: Improve typing._GenericAlias.__dir__ coverage
#103396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Apr 9, 2023
AlexWaygood
reviewed
Apr 9, 2023
AlexWaygood
reviewed
Apr 9, 2023
| dir_items = set(dir(Annotated[int, 4])) | ||
| for required_item in [ | ||
| '__args__', '__parameters__', '__origin__', | ||
| '__metadata__', |
There was a problem hiding this comment.
Note that the __metadata__ field is not currently documented, but really should be:
(No change requested here.)
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 10, 2023
…honGH-103396) (cherry picked from commit a28e2ce) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-103410 is a backport of this pull request to the 3.11 branch. |
8000
miss-islington
added a commit
that referenced
this pull request
Apr 10, 2023
(cherry picked from commit a28e2ce) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One interesting thing about
Callable: #103395 (comment)Did I cover all magic props / methods that we promise to have?
Do I need to add anything else to the test?
typing._GenericAlias.__dir__coverage #103395