10000 gh-96663: Add a better error message for __dict__-less classes setattr by Gobot1234 · Pull Request #103232 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-96663: Add a better error message for __dict__-less classes setattr #103232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 22, 2023
Merged

gh-96663: Add a better error message for __dict__-less classes setattr #103232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5da4039
Add a better error message for __dict__-less classes setattr
Gobot1234 Apr 4, 2023
dd9d18d
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 4, 2023
8395973
Fix tests
Gobot1234 Apr 4, 2023
cb1810f
Fix formatting nits
Gobot1234 Apr 4, 2023
88cbb1b
Fix another broken test
Gobot1234 Apr 4, 2023
9b11ec9
Fix more tests I think
Gobot1234 Apr 4, 2023
edc2797
Remove test for suggestions
Gobot1234 Apr 4, 2023
cac1d33
Remove the mention of __dict__ for del X().y when y doesn't exist
Gobot1234 Apr 4, 2023
0644b53
Try checking for a __setattr__ hook before mentioning __dict__
Gobot1234 Apr 4, 2023
8642463
Fix typo
Gobot1234 Apr 5, 2023
60e1f69
Fix import order
Gobot1234 Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add a better error message for __dict__-less classes setattr
  • Loading branch information
@Gobot1234
Gobot1234 committed Apr 4, 2023
commit 5da403906890e0232645334efcc0efed8dca534c
13 changes: 11 additions & 2 deletions Lib/test/test_class.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,22 +640,31 @@ class A:
pass
class B:
y = 0
__slots__ = ('z',)
__slots__ = ('z', "foo")

error_msg = "'A' object has no attribute 'x'"
with self.assertRaisesRegex(AttributeError, error_msg):
A().x
with self.assertRaisesRegex(AttributeError, error_msg):
del A().x

error_msg = "'B' object has no attribute 'x'"
error_msg = ("'B' object has no attribute 'x' and no "
"__dict__ for setting new attributes")
with self.assertRaisesRegex(AttributeError, error_msg):
B().x
with self.assertRaisesRegex(AttributeError, error_msg):
del B().x
with self.assertRaisesRegex(AttributeError, error_msg):
B().x = 0

with self.assertRaisesRegex(
AttributeError,
"'B' object has no attribute 'x' and no "
"__dict__ for setting new attributes. Did you mean: 'foo'"
""
):
B().fod = 1

error_msg = "'B' object attribute 'y' is read-only"
with self.assertRaisesRegex(AttributeError, error_msg):
del B().y
Expand Down
8 changes: 6 additions & 2 deletions Objects/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,8 +1546,10 @@ _PyObject_GenericSetAttrWithDict(PyObject *obj, PyObject *name,
if (dictptr == NULL) {
if (descr == NULL) {
PyErr_Format(PyExc_AttributeError,
"'%.100s' object has no attribute '%U'",
"'%.100s' object has no attribute '%U' and no "
"__dict__ for setting new attributes",
tp->tp_name, name);
set_attribute_error_context(obj, name);
}
else {
PyErr_Format(PyExc_AttributeError,
Expand Down Expand Up @@ -1577,9 +1579,11 @@ _PyObject_GenericSetAttrWithDict(PyObject *obj, PyObject *name,
}
else {
PyErr_Format(PyExc_AttributeError,
"'%.100s' object has no attribute '%U'",
"'%.100s' object has no attribute '%U' and no "
"__dict__ for setting new attributes",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the tests for this bit of code, are there any?

tp->tp_name, name);
}
set_attribute_error_context(obj, name);
}
done:
Py_XDECREF(descr);
Expand Down
0