8000 Add --tempdir option for test run by zooba · Pull Request #10322 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Add --tempdir option for test run #10322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2018
Merged

Add --tempdir option for test run #10322

merged 3 commits into from
Nov 17, 2018

Conversation

zooba
Copy link
Member
@zooba zooba commented Nov 4, 2018 •
edited
Loading

This allows changing particularly the drive where tests are run, which can help ensure that the best performance and sometimes features like symlinks are available.

I've only updated it from the default for the Window build on Azure Pipelines, as that is known to have slower performance on the C: drive compared to the work drive.

@zooba zooba added tests Tests in the Lib/test dir skip issue skip news labels Nov 4, 2018
@zooba
Copy link
Member Author
zooba commented Nov 4, 2018

Happy to change the name of the option, or convert it to an environment variable (which is where I started, but then preferred an option instead).

@zooba
Copy link
Member Author
zooba commented Nov 6, 2018

@vstinner I think you'd be a good person to review this as well, so I'll wait for your comments. But I also think this is very safe, so I won't wait forever :)

serhiy-storchaka
8000 serhiy-storchaka approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update comments around line 18 in main.py?

vstinner
vstinner requested changes Nov 13, 2018
View reviewed changes
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@zooba zooba merged commit 38df97a into python:master Nov 17, 2018
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@zooba zooba deleted the testtmp branch November 17, 2018 12:14
@bedevere-bot
Copy link

GH-10584 is a backport of this pull request to the 3.7 branch.
8000

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2018
@zooba @miss-islington
Add --tempdir option for test run (pythonGH-10322)
03774cc 
(cherry picked from commit 38df97a)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
miss-islington added a commit that referenced this pull request Nov 17, 2018
@miss-islington @zooba
Add --tempdir option for test run (GH-10322)
f415aa1 
(cherry picked from commit 38df97a)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.7 has failed when building commit f415aa1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/119/builds/836) and take a look at the build logs.
  4. Check if the failure is related to this commit (f415aa1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/119/builds/836

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': Failed to connect to github.com port 443: Connection refused

make: *** No rule to make target 'distclean'.  Stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zooba @bedevere-bot @miss-islington @vstinner @serhiy-storchaka @the-knights-who-say-ni
0