8000 Docs: improve the accuracy of the sqlite3.connect() timeout param by erlend-aasland · Pull Request #102900 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Docs: improve the accuracy of the sqlite3.connect() timeout param #102900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

Docs: improve the accuracy of the sqlite3.connect() timeout param #102900

merged 2 commits into from
Mar 22, 2023

Conversation

erlend-aasland
Copy link
Contributor

No description provided.

@erlend-aasland erlend-aasland added skip issue needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 22, 2023
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels Mar 22, 2023
@erlend-aasland
Copy link
Contributor Author

Relevant SQLite docs: https://www.sqlite.org/c3ref/busy_timeout.html

CAM-Gerlach
CAM-Gerlach reviewed Mar 22, 2023
View reviewed changes
Copy link
Member
@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor phrasing tweak, otherwise LGTM @erlend-aasland !

@erlend-aasland @CAM-Gerlach
Update Doc/library/sqlite3.rst
fc8da35 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, CAM!

CAM-Gerlach
CAM-Gerlach approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member
@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the your work, @erlend-aasland ! LGTM from me.

@erlend-aasland erlend 8000 -aasland merged commit c24f1f1 into python:main Mar 22, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs/timeout branch March 22, 2023 11:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2023
@erlend-aasland @CAM-Gerlach @miss-islington
Docs: improve the accuracy of the sqlite3.connect() timeout param (py…
57ddfd6 
…thonGH-102900)

(cherry picked from commit c24f1f1)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-bot
Copy link

GH-102908 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2023
@erlend-aasland 8000 @CAM-Gerlach @miss-islington
Docs: improve the accuracy of the sqlite3.connect() timeout param (py…
bf7aa63 
…thonGH-102900)

(cherry picked from commit c24f1f1)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-bot
Copy link

GH-102909 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 22, 2023
miss-islington added a commit that referenced this pull request Mar 22, 2023
@miss-islington @erlend-aasland @CAM-Gerlach
Docs: improve the accuracy of the sqlite3.connect() timeout param (GH…
2e0505a 
…-102900)

(cherry picked from commit c24f1f1)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull request Mar 22, 2023
@miss-islington @erlend-aasland @CAM-Gerlach
Docs: improve the accuracy of the sqlite3.connect() timeout param (GH…
9a1453b 
…-102900)

(cherry picked from commit c24f1f1)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@erlend-aasland @CAM-Gerlach @Fidget-Spinner
Docs: improve the accuracy of the sqlite3.connect() timeout param (py…
563cf60 
…thon#102900)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@erlend-aasland @CAM-Gerlach @warsaw
Docs: improve the accuracy of the sqlite3.connect() timeout param (py…
73b24da 
…thon#102900)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach
0