8000 gh-102839: remove AC for math.log by skirpichev · Pull Request #102863 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-102839: remove AC for math.log #102863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2023
Merged

gh-102839: remove AC for math.log #102863

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdbc875
gh-102839: remove AC for math.log
skirpichev Mar 20, 2023
828e330
Merge branch 'main' into 102839-math.log-noAC
skirpichev Mar 21, 2023
882066b
Update Misc/NEWS.d/next/Library/2023-03-20-12-21-19.gh-issue-102839.R…
skirpichev Mar 21, 2023
45c7eb4
Comment on AC removal
skirpichev Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Comment on AC removal
  • Loading branch information
@skirpichev
skirpichev committed Mar 21, 2023
commit 45c7eb41ed933516096f484b4c6648631301148e
2 changes: 2 additions & 0 deletions Modules/mathmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,6 +2284,8 @@ loghelper(PyObject* arg, double (*func)(double))
}


/* AC: cannot convert yet, see gh-102839 and gh-89381, waiting
for support of multiple signatures */
static PyObject *
math_log(PyObject *module, PyObject * const *args, Py_ssize_t nargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment about why it is not converted to AC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I did.

{
Expand Down
0