8000 GH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` by kumaraditya303 · Pull Request #102749 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-102748: remove legacy support for generator based coroutines from asyncio.iscoroutine #102749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 16, 2023
Merged

GH-102748: remove legacy support for generator based coroutines from asyncio.iscoroutine #102749

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4335f70
rm legacy support for generators as coroutines
kumaraditya303 Mar 16, 2023
f161b44
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 16, 2023
87792d5
add whatsnew
kumaraditya303 Mar 16, 2023
0e0897a
add test
kumaraditya303 Mar 16, 2023
05c0944
wrap lines
kumaraditya303 Mar 16, 2023
47caefd
Apply suggestions from code review
kumaraditya303 Mar 16, 2023
31049b1
Update Misc/NEWS.d/next/Library/2023-03-16-08-17-29.gh-issue-102748.W…
kumaraditya303 Mar 16, 2023
14ea9a6
Update Doc/whatsnew/3.12.rst
kumaraditya303 Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wrap lines
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Mar 16, 2023
commit 05c0944944529220c78605312c495dc250aa4fb0
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.12.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ asyncio
(Contributed by Itamar Ostricher and Pranav Thulasiram Bhat in :gh:`100344`.)

* :func:`asyncio.iscoroutine` now returns :const:`False` for generators as
:mod:`asyncio` does not supports legacy generator based coroutines.
:mod:`asyncio` does not supports legacy generator-based coroutines.
(Contributed by Kumar Aditya in :gh:`102748`.)

inspect
Expand Down
4 changes: 3 additions & 1 deletion Misc/NEWS.d/next/Library/2023-03-16-08-17-29.gh-issue-102748.WNACpI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
:func:`asyncio.iscoroutine` now returns :const:`False` for generators as :mod:`asyncio` does not supports legacy generator based coroutines. Patch by Kumar Aditya.
:func:`asyncio.iscoroutine` now returns :const:`False` for generators as
:mod:`asyncio` does not supports legacy generator-based coroutines.
Patch by Kumar Aditya.
0