8000 Exclude `ceval.c` from the C-analyzer tool by AlexWaygood · Pull Request #102735 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Exclude ceval.c from the C-analyzer tool #102735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Exclude ceval.c from the C-analyzer tool #102735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Exclude ceval.c from the C-analyzer tool 
The "check if generated files are up to date" CI check appears to be currently failing on all PRs (but not on pushes to main) 

See, for example:
- #94468
- #94468
- #102731

This appears to be because the C-analyzer tool doesn't like the `#line` directives introduced in 70185de. I'm advised by the message printed to the terminal in https://github.com/python/cpython/actions/runs/4428706945/jobs/7768216988#step:14:84 that this is the appropriate short-term fix!

Cc. @ericsnowcurrently
  • Loading branch information
@AlexWaygood
AlexWaygood authored Mar 15, 2023
commit 6da21981232914e208146897f6ddc795a909d2e8
5 changes: 5 additions & 0 deletions Tools/c-analyzer/cpython/_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,15 @@ def clean_lines(text):
# XXX Fix the parser.
EXCLUDED += clean_lines('''
# The tool should be able to parse these...

# The problem with xmlparse.c is that something
# has gone wrong where # we handle "maybe inline actual"
# in Tools/c-analyzer/c_parser/parser/_global.py.
Modules/expat/xmlparse.c

# The parser doesn't like the #line directives
# that originate from generated_cases.c.h
Python/ceval.c
''')

INCL_DIRS = clean_lines('''
Expand Down
0