-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-87868: Sort and remove duplicates in getenvironment() #102731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
aed39b7
gh-87868: correctly sort and remove duplicates in getenvironment()
aisk 4de761b
Merge branch 'main' into getenvironment
AlexWaygood 04f7d59
check null in normalize_environment
aisk c43abb2
Update Modules/_winapi.c
aisk 3f6319a
Update Modules/_winapi.c
aisk 8ef3b9c
Update Lib/test/test_subprocess.py
aisk 46491c5
Merge remote-tracking branch 'upstream/main' into getenvironment
aisk ca13205
Adapt latest changes from main branch
aisk f727004
Fix test case
aisk 6b9e873
update for review comments
aisk dd53528
add win32 related env validation tests
aisk 37fa2f2
fix memory leak
aisk fcd8b88
Merge branch 'main' into getenvironment
aisk 96754a1
Merge branch 'main' into getenvironment
aisk 47155b5
follow PEP7
aisk a204740
add error check
aisk 8ca7b8e
fix test
aisk b620bdb
better cleanup in error path
aisk 65c8483
fix a mem leak
aisk 2d2fd4d
refactor error handling
aisk 2096209
fix one off iteration and add test
aisk da55b3b
fix one env test on non windows platforms
aisk 5b17740
Merge branch 'main' into getenvironment
aisk bf5a555
using vector call
aisk 66fddbe
fix test on none windows platforms
aisk 2b82368
fix typo in test
aisk 5c581ea
fix test on linux
aisk 6b5d1da
revert line end modify and align codes with pep7
aisk bcd8910
Update Modules/_winapi.c
aisk 3423e13
Update Modules/_winapi.c
aisk 03a4f7e
Update Modules/_winapi.c
aisk 186d718
Update Modules/_winapi.c
aisk 8b074df
Update Modules/_winapi.c
aisk b675260
Update Modules/_winapi.c
aisk fb93eb1
Update Modules/_winapi.c
aisk f9d97eb
Update Modules/_winapi.c
aisk 6f3b7ce
Update Modules/_winapi.c
aisk b9b8d6e
Update Modules/_winapi.c
aisk 5fd7ebf
Update Modules/_winapi.c
aisk f87970a
Update Modules/_winapi.c
aisk cbdfa84
Update Lib/test/test_subprocess.py
aisk 8748103
only keep the last duplicated environment key
aisk 4aff3b4
split the normalize_environment function into two
aisk 67b8731
Update Lib/test/test_subprocess.py
aisk d02319e
remove the error check for PyList_GET_ITEM
aisk d1c794b
decref the vectorcall result
aisk 1763421
split normalze_keys into sort_keys and dedup_keys
aisk dbbaf1b
Update Modules/_winapi.c
aisk 176e90d
refactor sort_environment_keys to remove the goto error stuff
aisk d088083
refactor the dedup_environment_keys to get rid of the goto error stuff
aisk 471c8b8
fix a memory leak in `normalize_environment`
aisk a2dab93
revert the commit that moves key validation codes to the original place
aisk 6a2bbee
fixed a memory leak
aisk 22548cc
Update Modules/_winapi.c
aisk 63cf753
Update Modules/_winapi.c
aisk 91d091d
using int as return value rather than bool
aisk b053e2a
get rid of the goto error in normalize_environment
aisk 5dd6215
Update Misc/NEWS.d/next/Windows/2023-03-15-23-53-45.gh-issue-87868.4C…
aisk be49dae
Update Modules/_winapi.c
aisk 0aff1e9
Update Modules/_winapi.c
aisk 72fc36d
Update Modules/_winapi.c
aisk 725baec
Update Modules/_winapi.c
aisk 0a308be
Update Modules/_winapi.c
aisk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adapt latest changes from main branch
- Loading branch information
commit ca1320598b58b3efb0822a5582cf3b31bdeae71f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.