8000 gh-102615: Use `list` instead of `tuple` in `repr` of paramspec by sobolevn · Pull Request #102637 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-102615: Use list instead of tuple in repr of paramspec #102637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2023
Merged

gh-102615: Use list instead of tuple in repr of paramspec #102637

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e4620c
gh-102615: Use `list` instead of `tuple` in `repr` of paramspec
sobolevn Mar 13, 2023
4e12bd6
Apply suggestions from code review
sobolevn Mar 14, 2023
d226833
Update Lib/test/test_typing.py
sobolevn Mar 14, 2023
dc36254
Update Lib/test/test_typing.py
sobolevn Mar 14, 2023
3451d4d
Address review
sobolevn Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_typing.py 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
@sobolevn @AlexWaygood
sobolevn and AlexWaygood authored Mar 14, 2023
commit d226833e067c0f25daede3d7f580a6e2329d0c52
2 changes: 1 addition & 1 deletion Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3824,7 +3824,7 @@ class MyCallable(Generic[P, T]):

for obj, expected_repr in object_to_expected_repr.items():
with self.subTest(obj=obj, expected_repr=expected_repr):
self.assertEqual(repr(obj), MyCallable.__module__ + expected_repr)
self.assertEqual(repr(obj), f"{MyCallable.__module__}.{expected_repr}")

def test_eq_1(self):
self.assertEqual(Generic, Generic)
Expand Down
0