10000 gh-79940: skip `TestGetAsyncGenState` on wasm as it requires working sockets by tkren · Pull Request #102605 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets #102605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2023
Merged

gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets #102605

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab6bcf
TestGetAsyncGenState requires working sockets
tkren Mar 11, 2023
ea7431d
Delete 2023-03-11-11-14-01.gh-issue-79940.UH4d3k.rst
kumaraditya303 Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
TestGetAsyncGenState requires working sockets 
Skip `TestGetAsyncGenState` and restoring of the default event loop
policy in `test_inspect` if platform lacks working socket support.

Fixes #11590
  • Loading branch information
@tkren
tkren committed Mar 11, 2023
commit 6ab6bcfcfa3f4e283c77b29921b82f3aac3ae4a3
4 changes: 3 additions & 1 deletion Lib/test/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ def revise(filename, *args):


def tearDownModule():
asyncio.set_event_loop_policy(None)
if support.has_socket_support:
asyncio.set_event_loop_policy(None)


def signatures_with_lexicographic_keyword_only_parameters():
Expand Down Expand Up @@ -2326,6 +2327,7 @@ async def func(a=None):
{'a': None, 'gencoro': gencoro, 'b': 'spam'})


@support.requires_working_socket()
82A1 class TestGetAsyncGenState(unittest.IsolatedAsyncioTestCase):

def setUp(self):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2023-03-11-11-14-01.gh-issue-79940.UH4d3k.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix failed :mod:`test_inspect` tests on wasm32-emscripten and wasm32-wasi.
Patch by Thomas Krennwallner.
0