8000 gh-81057: Add a CI Check for New Unsupported C Global Variables by ericsnowcurrently · Pull Request #102506 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-81057: Add a CI Check for New Unsupported C Global Variables #102506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 14, 2023
Merged

gh-81057: Add a CI Check for New Unsupported C Global Variables #102506

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3651ee7
Print a helpful message when the globals check fails.
ericsnowcurrently Mar 7, 2023
1c1e0b0
Print the explanation even when the parser breaks.
ericsnowcurrently Mar 7, 2023
aa08d9d
Enable the CI globals check.
ericsnowcurrently Mar 7, 2023
94db0e4
Add the globals check to CI.
ericsnowcurrently Mar 7, 2023
68db07f
Drop the test.
ericsnowcurrently Mar 7, 2023
9ed998a
Fix the command.
ericsnowcurrently Mar 7, 2023
5ee7611
Add some temporary debugging code.
ericsnowcurrently Mar 7, 2023
bb1463e
Accommodate newer GCC versions.
ericsnowcurrently Mar 7, 2023
d9f45a8
Fix the "ignored" filename.
ericsnowcurrently Mar 7, 2023
f1e5827
Emit the message from the right script.
ericsnowcurrently Mar 7, 2023
d59e2af
Print the traceback.
ericsnowcurrently Mar 7, 2023
a959ccd
Let lineno be 0 for meta files.
ericsnowcurrently Mar 7, 2023
3390014
Allow meta files with flags.
ericsnowcurrently Mar 8, 2023
8f93550
Special-case <command-line>.
ericsnowcurrently Mar 8, 2023
76039c0
Flush stdout/stderr around the explanation.
ericsnowcurrently Mar 8, 2023
dc4ee3a
Print preprocessor errors by default.
ericsnowcurrently Mar 8, 2023
4c03fd0
Add a possible include dir for uuid.
ericsnowcurrently Mar 8, 2023
863e152
Add other possible include dirs.
ericsnowcurrently Mar 8, 2023
f230d79
Use Same Capitalization as Other Jobs
ericsnowcurrently Mar 14, 2023
08f9279
Add a make target.
ericsnowcurrently Mar 14, 2023
c220d54
Merge branch 'main' into enable-globals-ci-check
ericsnowcurrently Mar 14, 2023
9cc170c
Ignore a global that snuck in.
ericsnowcurrently Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Same Capitalization as Other Jobs 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
  • Loading branch information
@ericsnowcurrently @CAM-Gerlach
ericsnowcurrently and CAM-Gerlach authored Mar 14, 2023
commit f230d79fa5d80f0429e9c9e366f1d3a1c577cea4
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
run: make smelly
- name: Check limited ABI symbols
run: make check-limited-abi
- name: Check for Unsupported C Global Variables
- name: Check for unsupported C global variables
if: github.event_name == 'pull_request' # $GITHUB_EVENT_NAME
run: python3 Tools/c-analyzer/check-c-globals.py --format summary --traceback

Expand Down
0