[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101711

miss-islington · 2023-02-08T22:14:53Z

Lib/subprocess.py

gpshead · 2023-02-08T22:51:35Z

Doc/library/subprocess.rst

@@ -111,6 +111,14 @@ underlying :class:`Popen` interface can be used directly.
      Added the *text* parameter, as a more understandable alias of *universal_newlines*.
      Added the *capture_output* parameter.

+   .. versionchanged:: 3.11.2


this version number is wrong ever 8000 ywhere. 3.11.2 was just released.

bedevere-bot · 2023-02-08T22:51:45Z

zooba · 2023-02-08T23:43:22Z

Doc/library/subprocess.rst

@@ -111,6 +111,14 @@ underlying :class:`Popen` interface can be used directly.
      Added the *text* parameter, as a more understandable alias of *universal_newlines*.
      Added the *capture_output* parameter.

+   .. versionchanged:: 3.11.2


Suggested change

.. versionchanged:: 3.11.2

.. versionchanged:: 3.11.3

zooba · 2023-02-08T23:43:28Z

Doc/library/subprocess.rst

@@ -488,6 +496,14 @@ functions.
      *executable* parameter accepts a bytes and :term:`path-like object`
      on Windows.

+   .. versionchanged:: 3.11.2


Suggested change

.. versionchanged:: 3.11.2

.. versionchanged:: 3.11.3

zooba · 2023-02-08T23:43:32Z

Doc/library/subprocess.rst

@@ -1160,6 +1176,14 @@ calls these functions.
   .. versionchanged:: 3.3
      *timeout* was added.

+   .. versionchanged:: 3.11.2


Suggested change

.. versionchanged:: 3.11.2

.. versionchanged:: 3.11.3

zooba · 2023-02-08T23:43:36Z

Doc/library/subprocess.rst

@@ -1192,6 +1216,14 @@ calls these functions.
   .. versionchanged:: 3.3
      *timeout* was added.

+   .. versionchanged:: 3.11.2


Suggested change

.. versionchanged:: 3.11.2

.. versionchanged:: 3.11.3

zooba · 2023-02-08T23:43:41Z

Doc/library/subprocess.rst

@@ -1247,6 +1279,14 @@ calls these functions.
   .. versionadded:: 3.7
      *text* was added as a more readable alias for *universal_newlines*.

+   .. versionchanged:: 3.11.2


Suggested change

.. versionchanged:: 3.11.2

.. versionchanged:: 3.11.3

zooba · 2023-02-08T23:44:40Z

pythongh-101283: Improved fallback logic for subprocess with shell=Tr…

644134d

…ue on Windows (pythonGH-101286) (cherry picked from commit 23751ed) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>

miss-islington requested a review from gpshead as a code owner February 8, 2023 22:14

bedevere-bot added the awaiting review label Feb 8, 2023

This was referenced Feb 8, 2023

Undocumented risky behaviour in subprocess module #101283

Closed

gh-101283: Try to load the fallback cmd.exe by an absolute path #101286

Merged

bedevere-bot added the type-security A security issue label Feb 8, 2023

zooba reviewed Feb 8, 2023

View reviewed changes

Lib/subprocess.py Outdated Show resolved Hide resolved

Update Lib/subprocess.py

3762cc4

gpshead requested changes Feb 8, 2023

View reviewed changes

bedevere-bot removed the awaiting review label Feb 8, 2023

bedevere-bot added the awaiting changes label Feb 8, 2023

zooba approved these changes Feb 8, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Feb 8, 2023

miss-islington merged commit 51b079a into python:3.11 Feb 8, 2023

bedevere-bot removed the awaiting merge label Feb 8, 2023

miss-islington deleted the backport-23751ed-3.11 branch February 8, 2023 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101711

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101711

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101711

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101711

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment