8000 gh-101678: refactor the math module to use special functions from c11 by skirpichev · Pull Request #101679 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-101678: refactor the math module to use special functions from c11 #101679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 9, 2023
Merged

gh-101678: refactor the math module to use special functions from c11 #101679

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d202b5c
gh-101678: refactor the math module to use special functions from c11
skirpichev Feb 8, 2023
7d14105
Use libc's lgamma/tgamma instead of custom implementations
skirpichev Feb 8, 2023
468096b
Revert "Use libc's lgamma/tgamma instead of custom implementations"
skirpichev Feb 8, 2023
5b75ef8
Comment on custom implementations of tgamma/lgamma
skirpichev Feb 8, 2023
538810d
UPD commit msg: gh-101678: refactor the math module to use erf/erfc/l…
skirpichev Feb 8, 2023
fa76552
Grammar fix
skirpichev Feb 9, 2023
42829cb
Restore braces in m_log2 per PEP7
skirpichev Feb 9, 2023
27334d8
Merge branch 'main' into math-c11
skirpichev Feb 9, 2023
c097545
Merge branch 'main' into math-c11
skirpichev Feb 9, 2023
47970e2
Merge math_1_to_whatever() and math_1()
skirpichev Feb 9, 2023
bebbc79
Provide context for log1p workaround
skirpichev Feb 9, 2023
ee5e689
Revert "Merge math_1_to_whatever() and math_1()"
skirpichev Feb 9, 2023
06e9c8c
Fix issues prefixes
skirpichev Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge math_1_to_whatever() and math_1()
  • Loading branch information
@skirpichev
skirpichev committed Feb 9, 2023
commit 47970e268331c486e23fd7d25174292d3a9a2038
12 changes: 2 additions & 10 deletions Modules/mathmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,9 +875,7 @@ is_error(double x)
*/

static PyObject *
math_1_to_whatever(PyObject *arg, double (*func) (double),
PyObject *(*from_double_func) (double),
int can_overflow)
math_1(PyObject *arg, double (*func) (double), int can_overflow)
{
double x, r;
x = PyFloat_AsDouble(arg);
Expand All @@ -903,7 +901,7 @@ math_1_to_whatever(PyObject *arg, double (*func) (double),
/* this branch unnecessary on most platforms */
return NULL;

return (*from_double_func)(r);
return PyFloat_FromDouble(r);
}

/* variant of math_1, to be used when the function being wrapped is known to
Expand Down Expand Up @@ -951,12 +949,6 @@ math_1a(PyObject *arg, double (*func) (double))
OverflowError.
*/

static PyObject *
math_1(PyObject *arg, double (*func) (double), int can_overflow)
{
return math_1_to_whatever(arg, func, PyFloat_FromDouble, can_overflow);
}

static PyObject *
math_2(PyObject *const *args, Py_ssize_t nargs,
double (*func) (double, double), const char *funcname)
Expand Down
0