8000 Make use of TESTFN_ASCII in test_fileio by zware · Pull Request #101645 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Make use of TESTFN_ASCII in test_fileio #101645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

Make use of TESTFN_ASCII in test_fileio #101645

merged 1 commit into from
Feb 7, 2023

Conversation

zware
Copy link
Member
@zware zware commented Feb 7, 2023 •
edited by miss-islington
Loading

testBytesOpen requires an ASCII filename, but TESTFN usually isn't ASCII.

Automerge-Triggered-By: GH:zware

@zware
Make use of TESTFN_ASCII in test_fileio
7f2ce65
8000 
testBytesOpen requires an ASCII filename, but TESTFN usually isn't ASCII.
@zware zware added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 7, 2023
@zware zware self-assigned this Feb 7, 2023
@zware zware requested a review from gvanrossum February 7, 2023 16:51
gvanrossum
gvanrossum approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member
@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is an example of the danger of skipping tests...

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 6fd5eb6 into python:main Feb 7, 2023
@miss-islington
Copy link
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @zware, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6fd5eb640af19b535f4f2ba27b1b61b8d17f02e9 3.10

@bedevere-bot
Copy link

GH-101650 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2023
@zware @miss-islington
Make use of TESTFN_ASCII in test_fileio (pythonGH-101645)
a43eb2b 
testBytesOpen requires an ASCII filename, but TESTFN usually isn't ASCII.
(cherry picked from commit 6fd5eb6)

Co-authored-by: Zachary Ware <zach@python.org>
Automerge-Triggered-By: GH:zware
@zware zware deleted the fix_testBytesOpen branch February 7, 2023 17:30
ambv pushed a commit that referenced this pull request Feb 8, 2023
@miss-islington @zware
[3.11] Make use of TESTFN_ASCII in test_fileio (GH-101645) (#101650)
c38b4e7 
testBytesOpen requires an ASCII filename, but TESTFN usually isn't ASCII.
(cherry picked from commit 6fd5eb6)

Co-authored-by: Zachary Ware <zach@python.org>
@zware zware removed the needs backport to 3.10 only security fixes label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@miss-islington miss-islington

Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zware @miss-islington @bedevere-bot @gvanrossum
0