8000 gh-101334: Don't force USTAR format in test_tarfile. by gpshead · Pull Request #101572 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-101334: Don't force USTAR format in test_tarfile. #101572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2023
Merged

gh-101334: Don't force USTAR format in test_tarfile. #101572

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2597aad
gh-101334: Don't force USTAR format in test_tarfile.
gpshead Feb 5, 2023
5d4f43c
NEWS
gpshead Feb 5, 2023
b0bfa0e
re-add format to USTAR test, skip on high uid/gid.
gpshead Feb 5, 2023
5b8c07e
- trailing space
gpshead Feb 5, 2023
6aff621
fix skip logic for platforms w/o getuid and getgid.
gpshead Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000
Diff view
Diff view
Next Next commit
gh-101334: Don't force USTAR format in test_tarfile. 
That causes the test to fail when run using a high UID as that ancient format
cannot represent it. The current default (PAX) and the old default (GNU) both
support high UIDs.
  • Loading branch information
@gpshead
gpshead committed Feb 5, 2023
commit 2597aadec45120528a952a5e9e0ee058ed555f90
1 change: 0 additions & 1 deletion Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ def test_add_dir_getmember(self):
def add_dir_and_getmember(self, name):
with os_helper.temp_cwd():
with tarfile.open(tmpname, 'w') as tar:
tar.format = tarfile.USTAR_FORMAT
try:
os.mkdir(name)
tar.add(name)
Expand Down
0