8000 fix(tutorial,venv): replace PyPI description with link by Linkid · Pull Request #101506 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

fix(tutorial,venv): replace PyPI description with link #101506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix(tutorial,venv): replace PyPI description with link #101506

merged 1 commit into from
Feb 3, 2023

Conversation

Linkid
Copy link
Contributor
@Linkid Linkid commented Feb 1, 2023 •
edited
Loading

In the venv tutorial, the PyPI link is now attached to its title.

@Linkid Linkid requested a review from vsajip as a code owner February 1, 2023 21:56
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 1, 2023
hugovk
hugovk requested changes Feb 2, 2023
View reviewed changes
Doc/tutorial/venv.rst Outdated
:program:`pip`. By default ``pip`` will install packages from the Python
Package Index, <https://pypi.org>. You can browse the Python
:program:`pip`. By default ``pip`` will install packages from the `Python
Package Index, <https://pypi.org>`_. You can browse the Python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this comma:

image

Suggested change
Package Index, <https://pypi.org>`_. You can browse the Python
Package Index <https://pypi.org>`_. You can browse the Python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Good catch, I'll remove it. Thanks.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Linkid Linkid force-pushed the fix-tuto-venv-pypi-link branch from 958afb1 to fff1991 Compare February 2, 2023 21:51
@Linkid
fix(tutorial,venv): replace description with link
fff1991 
In the venv tutorial, the PyPI link is now attached to its title.
hugovk
hugovk approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hugovk hugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 2, 2023
@kumaraditya303 kumaraditya303 merged commit 45d014e into python:main Feb 3, 2023
@miss-islington
Copy link
Contributor

Thanks @Linkid for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2023
@Linkid @miss-islington
docs: replace PyPI description with link (pythonGH-101506)
6c6d187 
(cherry picked from commit 45d014e)

Co-authored-by: François Magimel <magimel.francois@gmail.com>
@bedevere-bot
Copy link

GH-101534 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2023
@Linkid @miss-islington
docs: replace PyPI description with link (pythonGH-101506)
25741e6 
(cherry picked from commit 45d014e)

Co-authored-by: François Magimel <magimel.francois@gmail.com>
@bedevere-bot
Copy link

GH-101535 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 3, 2023
miss-islington added a commit that referenced this pull request Feb 3, 2023
@miss-islington @Linkid
docs: replace PyPI description with link (GH-101506)
42b1404 
(cherry picked from commit 45d014e)

Co-authored-by: François Magimel <magimel.francois@gmail.com>
miss-islington added a commit that referenced this pull request Feb 3, 2023
@miss-islington @Linkid
docs: replace PyPI description with link (GH-101506)
4392bf6 
(cherry picked from commit 45d014e)

Co-authored-by: François Magimel <magimel.francois@gmail.com>
@Linkid
Copy link
Contributor Author
Linkid commented Feb 3, 2023

Hello. Thanks for the merge. I think this can also be backported to python 3.8 and python 3.7 too.

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Feb 3, 2023
@Linkid @iritkatriel
docs: replace PyPI description with link (python#101506)
ea0cf9c
@hugovk
Copy link
Member
hugovk commented Feb 3, 2023

Python 3.7 to 3.9 are in the security phase, which means we only merge security fixes.

See https://devguide.python.org/versions/

@Linkid Linkid deleted the fix-tuto-venv-pypi-link branch February 3, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Linkid @bedevere-bot @miss-islington @hugovk @kumaraditya303
0