8000 datetime.rst: fix combine() signature by belm0 · Pull Request #101490 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

datetime.rst: fix combine() signature #101490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023
Merged

datetime.rst: fix combine() signature #101490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
datetime.rst: fix combine() signature 
The default `tzinfo` param of the `combine()` signature pseudocode was erroneously `self.tzinfo`.

`self` has no meaning in the context of a classmethod, and the datetime class itself has no `tzinfo` attribute.  The correct default pseudocode is `time.tzinfo`, reflecting that the default is the `tzinfo` attribute of the `time` parameter.
  • Loading branch information
@belm0
belm0 authored Feb 1, 2023
commit 5bfc01e8a7c04f4ecd5a8a9da02b1c12ae1a6754
2 changes: 1 addition & 1 deletion Doc/library/datetime.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ Other constructors, all class methods:
microsecond of the result are all 0, and :attr:`.tzinfo` is ``None``.


.. classmethod:: datetime.combine(date, time, tzinfo=self.tzinfo)
.. classmethod:: datetime.combine(date, time, tzinfo=time.tzinfo)

Return a new :class:`.datetime` object whose date components are equal to the
given :class:`date` object's, and whose time components
Expand Down
0