Cache translation of individual components

python · barneygale · May 30, 2023 · Jan 28, 2023 · Jan 29, 2023 · Feb 15, 2023
commit bbd8cd603c71f87c948e11a1528a29536ae21827
@@ -68,23 +68,26 @@ def _is_wildcard_pattern(pat):
 _SWAP_SLASH_AND_NEWLINE = str.maketrans({'/': '\n', '\n': '/'})
 
 
+@functools.lru_cache()
+def _translate(pattern, recursive):
+    if recursive:
+        if pattern == '**\n':
+            return r'[\S\s]*^'
+        elif pattern == '**':
+            return r'[\S\s]*'
+        elif '**' in pattern:
+            raise ValueError("Invalid pattern: '**' can only be an entire path component")
+    return fnmatch._translate(pattern)
+
+
 @functools.lru_cache()
 def _make_matcher(path_cls, pattern, recursive):
     pattern = path_cls(pattern)
     if not pattern._parts:
         raise ValueError("empty pattern")
     result = [r'\A' if pattern._drv or pattern._root else '^']
     for line in pattern._lines_normcase.splitlines(keepends=True):
-        if recursive:
-            if line == '**\n':
-                result.append(r'[\S\s]*^')
-                continue
-            elif line == '**':
-                result.append(r'[\S\s]*')
-                continue
-            elif '**' in line:
-                raise ValueError("Invalid pattern: '**' can only be an entire path component")
-        result.append(fnmatch._translate(line))
+        result.append(_translate(line, recursive))
     result.append(r'\Z')
     return re.compile(''.join(result), flags=re.MULTILINE)