8000 gh-92123: Adapt _elementtree to multi-phase init (PEP 489) by erlend-aasland · Pull Request #101285 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-92123: Adapt _elementtree to multi-phase init (PEP 489) #101285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jan 24, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4d0b34e
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
3489b1b
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
c2089ff
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
acafd9c
Fix cherry-picks
erlend-aasland Jan 20, 2023
18109aa
gh-92123: use PyModule_GetState in _elementtree
erlend-aasland Jan 22, 2023
af83b00
Add get_elementtree_state_by_cls() helper
erlend-aasland Jan 22, 2023
96e6239
_elementtree.Element.append
erlend-aasland Jan 22, 2023
27c7dd8
_elementtree.Element.__copy__
erlend-aasland Jan 22, 2023
74eb390
_elementtree.Element.__setstate__
erlend-aasland Jan 22, 2023
7f639a7
_elementtree.Element.extend
erlend-aasland Jan 22, 2023
0b2a670
_elementtree.Element.find
erlend-aasland Jan 22, 2023
5502d85
_elementtree.Element.findtext
erlend-aasland Jan 22, 2023
0546b43
_elementtree.Element.findall
erlend-aasland Jan 22, 2023
863db65
_elementtree.Element.iterfind
erlend-aasland Jan 22, 2023
9861b4e
_elementtree.Element.iter
erlend-aasland Jan 22, 2023
c012ed0
_elementtree.Element.itertext
erlend-aasland Jan 22, 2023
2aff87d
_elementtree.Element.makeelement
erlend-aasland Jan 22, 2023
e41f38f
Add get_elementtree_state_by_type() helper
erlend-aasland Jan 22, 2023
c904083
_elementtree_Element___deepcopy___impl
erlend-aasland Jan 22, 2023
26656f1
element_setitem
erlend-aasland Jan 22, 2023
381c8d8
element_ass_subscr
erlend-aasland Jan 22, 2023
af6a4e9
elementiter_next
erlend-aasland Jan 22, 2023
ae51faf
treebuilder_new
erlend-aasland Jan 22, 2023
85b6b96
xmlparser_new
erlend-aasland Jan 22, 2023
5290718
clinic-state
erlend-aasland Jan 22, 2023
2224356
Remove ET_STATE_GLOBAL macro
erlend-aasland Jan 22, 2023
6ca25df
Multi-phase init
erlend-aasland Jan 22, 2023
de8ec94
Add NEWS
erlend-aasland Jan 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
_elementtree.Element.findtext
  • Loading branch information
erlend-aasland committed Jan 24, 2023
commit 5502d8572ff62d9535916fd318a4f19e50159edb
10 changes: 6 additions & 4 deletions Modules/_elementtree.c
Original file line number Diff line number Diff line change
Expand Up @@ -1272,20 +1272,22 @@ _elementtree_Element_find_impl(ElementObject *self, PyTypeObject *cls,
/*[clinic input]
_elementtree.Element.findtext

cls: defining_class
/
path: object
default: object = None
namespaces: object = None

[clinic start generated code]*/

static PyObject *
_elementtree_Element_findtext_impl(ElementObject *self, PyObject *path,
PyObject *default_value,
_elementtree_Element_findtext_impl(ElementObject *self, PyTypeObject *cls,
PyObject *path, PyObject *default_value,
PyObject *namespaces)
/*[clinic end generated code: output=83b3ba4535d308d2 input=b53a85aa5aa2a916]*/
/*[clinic end generated code: output=6af7a2d96aac32cb input=32f252099f62a3d2]*/
{
Py_ssize_t i;
elementtreestate *st = ET_STATE_GLOBAL;
elementtreestate *st = get_elementtree_state_by_cls(cls);

if (checkpath(path) || namespaces != Py_None)
return PyObject_CallMethodObjArgs(
Expand Down
12 changes: 6 additions & 6 deletions Modules/clinic/_elementtree.c.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0